Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInsert missing subject. #175
Merged
Conversation
An alternative way to make the sentence grammatical would be to remove the comma before "but". However, this would have the effect of making "It" (the solution) be the subject of "would love"; as solutions are typically incapable of love, it is dubious that this is the author's original intended meaning. Therefore, the insertion of "I" is the fix that most likely preserves the author's intent.
|
Thanks a lot! |
haacked
added a commit
that referenced
this pull request
Nov 4, 2018
haacked
added a commit
that referenced
this pull request
Nov 4, 2018
haacked
added a commit
that referenced
this pull request
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
david-mitchell commentedJan 29, 2015
An alternative way to make the sentence grammatical would be to remove the comma before "but". However, this would have the effect of making "It" (the solution) be the subject of "would love"; as solutions are typically incapable of love, it is dubious that this is the author's original intended meaning. Therefore, the insertion of "I" is the fix that most likely preserves the author's intent.