★ wanayoo — archive 1999 https://github.com/microsoft/java-debug/pull/178Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the project's build errors in JDK 9/10 #178

Merged
merged 2 commits into from May 23, 2018
Merged

Fix the project's build errors in JDK 9/10 #178

merged 2 commits into from May 23, 2018

Conversation

@testforstephen
Copy link
Contributor

@testforstephen testforstephen commented May 23, 2018

Signed-off-by: Jinbo Wang jinbwan@microsoft.com

Fix the issue #145.

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@testforstephen testforstephen requested review from akaroml, andxu and yaohaizh May 23, 2018
<profile>
<id>default-tools.jar</id>
<activation>
<jdk>(,9)</jdk>

This comment has been minimized.

@yaohaizh

yaohaizh May 23, 2018

9 is not official supported by Oracle. Just start with 10 is okay.

This comment has been minimized.

@testforstephen

testforstephen May 23, 2018
Author Contributor

It represents the range < 9

* This fix is only for the JDI implementation by JDK. Other JDI implementations (such as JDT) doesn't have the impact.
*/
for (LaunchingConnector con : connectors) {
if (con.getClass().getName().equals("com.sun.tools.jdi.SunCommandLineLauncher")) {

This comment has been minimized.

@yaohaizh

yaohaizh May 23, 2018

Make the string final static value as the other values.

This comment has been minimized.

@testforstephen

testforstephen May 23, 2018
Author Contributor

Nice. Fixed.

@testforstephen testforstephen dismissed stale reviews from yaohaizh, akaroml, and andxu via 8612e74 May 23, 2018
@testforstephen testforstephen merged commit 3a3c2d0 into master May 23, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@testforstephen testforstephen deleted the jinbo_build branch May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.