Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix the project's build errors in JDK 9/10 #178
Merged
Conversation
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
| <profile> | ||
| <id>default-tools.jar</id> | ||
| <activation> | ||
| <jdk>(,9)</jdk> |
yaohaizh
May 23, 2018
9 is not official supported by Oracle. Just start with 10 is okay.
9 is not official supported by Oracle. Just start with 10 is okay.
testforstephen
May 23, 2018
Author
Contributor
It represents the range < 9
It represents the range < 9
com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/DebugUtility.java
Outdated
| * This fix is only for the JDI implementation by JDK. Other JDI implementations (such as JDT) doesn't have the impact. | ||
| */ | ||
| for (LaunchingConnector con : connectors) { | ||
| if (con.getClass().getName().equals("com.sun.tools.jdi.SunCommandLineLauncher")) { |
yaohaizh
May 23, 2018
Make the string final static value as the other values.
Make the string final static value as the other values.
testforstephen
May 23, 2018
Author
Contributor
Nice. Fixed.
Nice. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
Fix the issue #145.