★ wanayoo — archive 1999 https://github.com/allure-framework/allure-java/pull/429Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add step in allure report for spock framework #429

Open
wants to merge 11 commits into
base: master
from

Conversation

@alexey-shnaydmiller
Copy link

@alexey-shnaydmiller alexey-shnaydmiller commented Mar 4, 2020

Context

Checklist

commons lang3 collections4
add step
add step for test
check step in test
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Mar 4, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

alexey-shnaydmiller
Шнайдмиллер Алексей Давыдович


Шнайдмиллер Алексей Давыдович seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

add params
add param in test
@alexey-shnaydmiller alexey-shnaydmiller requested a review from baev Sep 17, 2020
alexey-shnaydmiller and others added 4 commits Sep 17, 2020
Шнайдмиллер Алексей Давыдович Шнайдмиллер Алексей Давыдович
@baev
Copy link
Member

@baev baev commented Sep 17, 2020

as far as I get from test you provided -- framework blocks are always displayed before all the steps (from allure)?

@alexey-shnaydmiller
Copy link
Author

@alexey-shnaydmiller alexey-shnaydmiller commented Sep 17, 2020

The test shows that the allure report prints all the blocks from the spock. Depending on which block of the spock is used, it is printed in the report.

@baev
Copy link
Member

@baev baev commented Sep 17, 2020

I mean if you have test like this:

given: "given"
step "given step"
when: "when"
step "when step"
then: "then"
step "then step"

you'll see the following scenario in the report:

"given"
"when"
"then"
"given step"
"when step"
"then step"

instead of correct nesting

"given"
    "given step"
"when"
    "when step"
"then"
    "then step"

or flat

"given"
"given step"
"when"
"when step"
"then"
"then step"
@alexey-shnaydmiller
Copy link
Author

@alexey-shnaydmiller alexey-shnaydmiller commented Sep 17, 2020

I get it. It was just done not to write a Step. I'll fix that shortcoming tomorrow.

@baev
Copy link
Member

@baev baev commented Sep 17, 2020

that is the main concern about this pull request. A wish to find a way to emit events when block start in order to support steps and attachments within blocks. Otherwise we'll immediately get an issue complaining about that.

Overall, I see that this one did improve integration for spock users in some way, so I'm down to merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.