★ wanayoo — archive 1999 https://github.com/angular/angular/issues/2335Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescriptification cleanup #2335

Closed
2 tasks done
tbosch opened this issue Jun 4, 2015 · 11 comments
Closed
2 tasks done

Typescriptification cleanup #2335

tbosch opened this issue Jun 4, 2015 · 11 comments
Assignees
Milestone

Comments

@tbosch
Copy link
Contributor

tbosch commented Jun 4, 2015

After all sources have been converted to TS, we should clean up our project:

  • remove *.es6, *.cjs from being transpiled
  • publish ts sources on npm and remove folder atscript in our npm releases
@naomiblack
Copy link
Contributor

naomiblack commented Jun 4, 2015

@ttowncompiled please bug @jeffbcross for help if you get stuck on any of these.

@toedter
Copy link

toedter commented Jun 5, 2015

+1, would you also consider to publish the *.d.ts files within the (alpha) releases at code.angularjs.org?

@jomeier
Copy link
Contributor

jomeier commented Jun 5, 2015

@toedter Definitely support this idea. @alexeagle put an d.ts file online today even it is for Alpha 22. Would appreciate if there's a way to get the proper d.ts files for each alpha instead of searching hacks in the net. Would make things a lot easier. But they are working on it.

@alexeagle
Copy link
Contributor

alexeagle commented Jun 5, 2015

Yes we will distribute the typings via the expected channels. Follow #1803

@ttowncompiled
Copy link
Contributor

ttowncompiled commented Jun 12, 2015

After spending most of the week working on this, I feel that this is an issue much more convoluted than we originally thought. I'm not sure if I have the knowledge or expertise to accomplish this on my own. While it would be really nice to have traceur removed from our build, I'm under the impression that no one is blocked on this issue. If otherwise, please note. Therefore, I would like to postpone until I can receive help from someone who has a much better working knowledge of our build path.

@jeffbcross
Copy link
Contributor

jeffbcross commented Jun 12, 2015

I think it'd be good for someone with more familiarity of our build process and its history to pair with @ttowncompiled on this. Maybe it could wait until the week of June 20th (Alpha 29) to pick this back up?

@naomiblack naomiblack modified the milestones: alpha-28, alpha-27 Jun 12, 2015
@naomiblack
Copy link
Contributor

naomiblack commented Jun 12, 2015

sounds reasonable. punting to alpha-28 so we can spend some more time on it.

@naomiblack
Copy link
Contributor

naomiblack commented Jun 19, 2015

I'm pushing this to alpha-30. @ttowncompiled has made good progress but we need to make a decision re: output to systemjs or commonjs. Ian will summarize in a doc and we'll review on Monday June 22 at the meeting.

@IgorMinar
Copy link
Contributor

IgorMinar commented Jun 19, 2015

something to be aware of when removing traceur is that typescript currently emits incorrect sloppy mode code instead of strict mode code. this is a significant issue that we need to be aware because it changes the behavior of the transpiled code. see microsoft/TypeScript#3576

@alexeagle
Copy link
Contributor

alexeagle commented Jul 1, 2015

Moved some parts of this:
remove traceur: #2829
rtts_assert: #2830

Removed a couple items we don't plan to do now.

Otherwise, this is already done.

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants