★ wanayoo — archive 1999 https://github.com/djm/python-scrapyd-api/issues/7Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] need to add the daemonstatus api for the new version of scrapyd #7

Open
BruceDone opened this issue Mar 28, 2016 · 5 comments

Comments

@BruceDone
Copy link

@BruceDone BruceDone commented Mar 28, 2016

Hi all:
since the scrapyd server has add the new api of daemonstatus.json

here is the code
https://github.com/scrapy/scrapyd/blob/master/scrapyd/webservice.py

here is the doc
https://scrapyd.readthedocs.org/en/latest/api.html#daemonstatus-json

i think may be need to update the code and add this new api to the project

@Digenis
Copy link

@Digenis Digenis commented Mar 28, 2016

daemonstatus.json is not in a scrapyd release yet
but I don't see why it shouldn't make it to the next.

@djm
Copy link
Owner

@djm djm commented Mar 28, 2016

Yup, as @Digenis noted in #5, this is not in a stable branch yet.

It has also changed within the last month so I'm not certain we should be relying on it being a stable API just yet.

but I don't see why it shouldn't make it to the next.

@Digenis do you have any more information on this? I can't find much info set in stone about scrapyd's release process.

@Digenis
Copy link

@Digenis Digenis commented Mar 29, 2016

The change was only a bugfix.
I don't think we should drop daemonstatus from scrapyd
There are other recently introduced features that should be dropped.
The reason you can't rely on it is because it's not tagged in a release yet.

Regarding releases, there are currently no conventions.
The odd-even convention for unstable-stable releases
is finally abandoned by scrapy.
I'm currently doing an effort to fix the setups of existing releases of scrapyd
which have erroneously remained with obsolete scrapy dependencies
and python2.6 support for too long. I think the setup scripts are important
because of the amount of people who accidentally end up with broken installations.
I'm done with the 1.0 branch, I'll do the same on 1.1
and then some cleanup and testing towards a 1.2 release.
Any help on this is welcome.

@djm
Copy link
Owner

@djm djm commented Mar 29, 2016

Thanks @Digenis.

I will likely start work on supporting daemonstatus in a branch our side so that we are ready to release as soon as scrapyd is at the point where it can be.

I'll leave this ticket open to track progress.

@tyong920
Copy link

@tyong920 tyong920 commented Oct 16, 2018

daemonstatus.json is now stable. Please add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.