Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[Dictionary] changes from hilitedLine to imageSource #6312
Merged
Conversation
docs/dictionary/property/icon.lcdoc
Outdated
| 4. The object's stack | ||
| 5. The object's stack's mainstack (if a substack) | ||
| 6. The object's stack's mainstack's substacks | ||
| 7. The list of open stacks, in order they were loaded |
livecodeali
Mar 6, 2018
Member
This slightly loses the sense of the original's iteration up the owner chain before you get to the object's stack's behavior... mind you, I'm not really sure how to render that in markdown. It might work to use an unordered list instead, and prefix with the original labels, eg
* 1) The stack of the object's <behavior> (if applicable)
* 2) The stack of the owner of the object's <behavior> (if applicable)
* ...
* n) The stack of the object's stack's <behavior> (if applicable)
* A) The object's stack
etc
This slightly loses the sense of the original's iteration up the owner chain before you get to the object's stack's behavior... mind you, I'm not really sure how to render that in markdown. It might work to use an unordered list instead, and prefix with the original labels, eg
* 1) The stack of the object's <behavior> (if applicable)
* 2) The stack of the owner of the object's <behavior> (if applicable)
* ...
* n) The stack of the object's stack's <behavior> (if applicable)
* A) The object's stack
etc
docs/dictionary/property/icon.lcdoc
Outdated
| * a. The object's stack | ||
| * b. The object's stack's mainstack (if a substack) | ||
| * c. The object's stack's mainstack's substacks | ||
| * d. The list of open stacks, in order they were loaded |
livecodeali
Mar 12, 2018
Member
I think capital A,B,C,D works better here to distinguish the from the n of the previous part
I think capital A,B,C,D works better here to distinguish the from the n of the previous part
| A) The object's stack | ||
| B) The object's stack's mainstack (if a substack) | ||
| C) The object's stack's mainstacks substacks | ||
| D) The list of open stacks, in order they were loaded |
livecodeali
Mar 12, 2018
Member
The list structure from the icon property should be replicated here as well
The list structure from the icon property should be replicated here as well
|
@livecode-vulcan review ok 5dccd12 |
|
|
livecode-vulcan
added a commit
that referenced
this pull request
May 2, 2018
[Dictionary] changes from hilitedLine to imageSource property/hilitedLine.lcdoc - Fixed broken link property/hilitePattern.lcdoc - Fixed broken link function/hostNameToAddress.lcdoc - Fixed broken link property/HTMLText.lcdoc - Fixed misdirected reference keyword/http.lcdoc - Slightly formatted Important note in the result keyword/https.lcdoc - Slightly formatted Important note in the result property/icon.lcdoc - Formatted ordered list. Fixed broken link. property/iconic.lcdoc - Removed leading whitespace from unordered list to not display as code. property/ID.lcdoc - Changed type of a reference to go to an entry that exists. message/IDChanged.lcdoc - Removed leading whitespace from unordered list to not display as code. property/imageSource.lcdoc - Formatted ordered list. Removed brackets from mentions of imageID, imageName, imageURL outside of syntax, as the text wasn’t displaying.
|
854e615
into
livecode:develop-9.0
4 checks passed
4 checks passed
continuous-integration/vulcan/cla
Contributor Agreement signed by @livecodesam
continuous-integration/vulcan/pr
The Vulcan build succeeded on 13 builders
continuous-integration/vulcan/review
Approved by reviewer @livecodepanos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
property/hilitedLine.lcdoc - Fixed broken link
property/hilitePattern.lcdoc - Fixed broken link
function/hostNameToAddress.lcdoc - Fixed broken link
property/HTMLText.lcdoc - Fixed misdirected reference
keyword/http.lcdoc - Slightly formatted Important note in the result
keyword/https.lcdoc - Slightly formatted Important note in the result
property/icon.lcdoc - Formatted ordered list. Fixed broken link.
property/iconic.lcdoc - Removed leading whitespace from unordered list to not display as code.
property/ID.lcdoc - Changed type of a reference to go to an entry that exists.
message/IDChanged.lcdoc - Removed leading whitespace from unordered list to not display as code.
property/imageSource.lcdoc - Formatted ordered list. Removed brackets from mentions of imageID, imageName, imageURL outside of syntax, as the text wasn’t displaying.