★ wanayoo — archive 1999 https://github.com/nodejs/node/commit/2089814b67Nouvelle recherche | Portail wanayoo
Skip to content
Permalink
Browse files
test: properly tag anonymous namespaces
For tests that use anonymous namespaces, some tagged the close
of the namespace with 'namespace' while others used
'anonymous namespace'. It was suggested I should use
'anonymous namespace' in a recent PR review so make all of the
tests consistent with this.

PR-URL: #18583
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
mhdawson authored and MylesBorins committed Feb 21, 2018
1 parent a667ac1 commit 2089814b67e1211ce01f2f5b287c6f6cc7198cf9
@@ -54,6 +54,6 @@ napi_value Init(napi_env env, napi_value exports) {
return exports;
}

} // namespace
} // anonymous namespace

NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
@@ -28,6 +28,6 @@ napi_value Init(napi_env env, napi_value exports) {
return exports;
}

} // namespace
} // anonymous namespace

NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
@@ -22,6 +22,6 @@ void Initialize(Local<Object> exports) {
NODE_SET_METHOD(exports, "getTriggerAsyncId", GetTriggerAsyncId);
}

} // namespace
} // anonymous namespace

NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
@@ -109,6 +109,6 @@ void Initialize(Local<Object> exports) {
NODE_SET_METHOD(exports, "getResource", GetResource);
}

} // namespace
} // anonymous namespace

NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
@@ -69,6 +69,6 @@ void Initialize(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "testResolveAsync", TestResolveAsync);
}

} // namespace
} // anonymous namespace

NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
@@ -26,6 +26,6 @@ void Initialize(Local<Object> exports) {
NODE_SET_METHOD(exports, "makeCallback", MakeCallback);
}

} // namespace
} // anonymous namespace

NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
@@ -34,6 +34,6 @@ void Initialize(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "makeCallback", MakeCallback);
}

} // namespace
} // anonymous namespace

NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
@@ -398,7 +398,7 @@ static const std::string WsHandshakeRequest(const std::string& target_id) {
"Sec-WebSocket-Key: aaa==\r\n"
"Sec-WebSocket-Version: 13\r\n\r\n";
}
} // namespace
} // anonymous namespace


TEST_F(InspectorSocketServerTest, InspectorSessions) {

0 comments on commit 2089814

Please sign in to comment.