src: allow --perf-(basic-)?prof in NODE_OPTIONS

PR-URL: #17600 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
nodejs · Feb 21, 2018 · 464df6d9b5a44abe00c2ed670e3a94b9021d061d · 464df6d
1 parent 51a8e1d
commit 464df6d9b5a44abe00c2ed670e3a94b9021d061d
Showing with 13 additions and 0 deletions.

+2 −0 doc/api/cli.md

+2 −0 src/node.cc

+9 −0 test/parallel/test-cli-node-options.js
diff --git a/doc/api/cli.md b/doc/api/cli.md
@@ -475,6 +475,8 @@ Node options that are allowed are:
 V8 options that are allowed are:
 - `--abort-on-uncaught-exception`
 - `--max-old-space-size`
+- `--perf-basic-prof`
+- `--perf-prof`
 - `--stack-trace-limit`
 
 ### `NODE_PENDING_DEPRECATION=1`

diff --git a/src/node.cc b/src/node.cc
@@ -3871,6 +3871,8 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
     "--icu-data-dir",
 
     // V8 options (define with '_', which allows '-' or '_')
+    "--perf_prof",
+    "--perf_basic_prof",
     "--abort_on_uncaught_exception",
     "--max_old_space_size",
     "--stack_trace_limit",

diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js
@@ -26,6 +26,15 @@ expect('--zero-fill-buffers', 'B\n');
 expect('--v8-pool-size=10', 'B\n');
 expect('--trace-event-categories node', 'B\n');
 
+if (!common.isWindows) {
+  expect('--perf-basic-prof', 'B\n');
+}
+
+if (common.isLinux && ['arm', 'x64', 'mips'].includes(process.arch)) {
+  // PerfJitLogger is only implemented in Linux.
+  expect('--perf-prof', 'B\n');
+}
+
 if (common.hasCrypto) {
   expect('--use-openssl-ca', 'B\n');
   expect('--use-bundled-ca', 'B\n');