★ wanayoo — archive 1999 https://github.com/nodejs/node/commit/72f4a830d7Nouvelle recherche | Portail wanayoo
Skip to content
Permalink
Browse files
build: tidy up additional libraries on Windows
The report functionality that depended on `Dbghelp.lib` and `Psapi.lib`
are actually in `src/debug_utils.cc` and are not dependent on the
report functionality being enabled.

PR-URL: #27138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
richardlau committed Apr 11, 2019
1 parent 06c803d commit 72f4a830d7c387d9d8f47ff1b5ccf98244032733
Showing with 7 additions and 31 deletions.
  1. +7 −31 node.gyp
@@ -345,16 +345,7 @@
],
'conditions': [
['OS=="win"', {
'libraries': [
'dbghelp.lib',
'PsApi.lib',
'Ws2_32.lib',
],
'dll_files': [
'dbghelp.dll',
'PsApi.dll',
'Ws2_32.dll',
],
'libraries': [ 'Ws2_32' ],
}],
],
}],
@@ -623,7 +614,10 @@
],
}],
],
'libraries': [ '-lpsapi.lib' ]
'libraries': [
'Dbghelp',
'Psapi',
],
}],
[ 'node_use_etw=="true"', {
'defines': [ 'HAVE_ETW=1' ],
@@ -718,16 +712,7 @@
],
'conditions': [
['OS=="win"', {
'libraries': [
'dbghelp.lib',
'PsApi.lib',
'Ws2_32.lib',
],
'dll_files': [
'dbghelp.dll',
'PsApi.dll',
'Ws2_32.dll',
],
'libraries': [ 'Ws2_32' ],
}],
],
}],
@@ -1083,16 +1068,7 @@
],
'conditions': [
['OS=="win"', {
'libraries': [
'dbghelp.lib',
'PsApi.lib',
'Ws2_32.lib',
],
'dll_files': [
'dbghelp.dll',
'PsApi.dll',
'Ws2_32.dll',
],
'libraries': [ 'Ws2_32' ],
}],
],
}],

0 comments on commit 72f4a83

Please sign in to comment.