★ wanayoo — archive 1999 https://github.com/nodejs/node/commit/7b0d867389Nouvelle recherche | Portail wanayoo
Skip to content
Permalink
Browse files
build: fix test failures not failing Travis builds
The exit code of the make command used to execute tests was being lost
after being piped through to grep.

PR-URL: #27176
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
  • Loading branch information
richardlau committed Apr 12, 2019
1 parent 25df3c1 commit 7b0d8673898e65a368108264c77bccaa3e004028
Showing with 1 addition and 0 deletions.
  1. +1 −0 .travis.yml
@@ -65,4 +65,5 @@ jobs:
- make -j2 > /dev/null
- make -j1 build-addons build-js-native-api-tests build-node-api-tests > /dev/null
script:
- set -o pipefail
- JOBS=2 FLAKY_TESTS=dontcare make -s -j1 V= test-ci | grep -F -e "---" -e "..." -v

0 comments on commit 7b0d867

Please sign in to comment.