test: apply promises API to fourth appendFile test

Add tests for `fs.promises.appendFile()` to the fourth (of five) test case in `test-fs-access`. (The previous test cases already have promises API versions.) PR-URL: #21131 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
nodejs · Jun 4, 2018 · aa9dbf666bc34edbcbc2b02ecadcc08bd070d254 · aa9dbf6
1 parent 185b9e4
commit aa9dbf666bc34edbcbc2b02ecadcc08bd070d254
Unified Split

Showing with 42 additions and 21 deletions.

+42 −21 test/parallel/test-fs-append-file.js
diff --git a/test/parallel/test-fs-append-file.js b/test/parallel/test-fs-append-file.js
@@ -132,29 +132,51 @@ const throwNextTick = (e) => { process.nextTick(() => { throw e; }); };
    .catch(throwNextTick);
 }
-  
-// test that appendFile accepts numbers.
-  
-const filename4 = join(tmpdir.path, 'append4.txt');
-  
-fs.writeFileSync(filename4, currentFileData);
+  
+// test that appendFile accepts numbers (callback API)
+  
+{
+  
+  const filename = join(tmpdir.path, 'append-numbers.txt');
+  
+  fs.writeFileSync(filename, currentFileData);
-  
-const m = 0o600;
-  
-fs.appendFile(filename4, n, { mode: m }, function(e) {
-  
-  assert.ifError(e);
+  
+  const m = 0o600;
+  
+  fs.appendFile(filename, n, { mode: m }, common.mustCall((e) => {
+  
+    assert.ifError(e);
-  
-  ncallbacks++;
+  
+    // windows permissions aren't unix
+  
+    if (!common.isWindows) {
+  
+      const st = fs.statSync(filename);
+  
+      assert.strictEqual(st.mode & 0o700, m);
+  
+    }
-  
-  // windows permissions aren't unix
-  
-  if (!common.isWindows) {
-  
-    const st = fs.statSync(filename4);
-  
-    assert.strictEqual(st.mode & 0o700, m);
-  
-  }
+  
+    fs.readFile(filename, common.mustCall((e, buffer) => {
+  
+      assert.ifError(e);
+  
+      assert.strictEqual(Buffer.byteLength(String(n)) + currentFileData.length,
+  
+                         buffer.length);
+  
+    }));
+  
+  }));
+  
+}
-  
-  fs.readFile(filename4, function(e, buffer) {
-  
-    assert.ifError(e);
-  
-    ncallbacks++;
-  
-    assert.strictEqual(Buffer.byteLength(String(n)) + currentFileData.length,
-  
-                       buffer.length);
-  
-  });
-  
-});
+  
+// test that appendFile accepts numbers (promises API)
+  
+{
+  
+  const filename = join(tmpdir.path, 'append-numbers-promises.txt');
+  
+  fs.writeFileSync(filename, currentFileData);
+  
+
+  
+  const m = 0o600;
+  
+  fs.promises.appendFile(filename, n, { mode: m })
+  
+    .then(common.mustCall(() => {
+  
+      // windows permissions aren't unix
+  
+      if (!common.isWindows) {
+  
+        const st = fs.statSync(filename);
+  
+        assert.strictEqual(st.mode & 0o700, m);
+  
+      }
+  
+
+  
+      return fs.promises.readFile(filename);
+  
+    }))
+  
+    .then((buffer) => {
+  
+      assert.strictEqual(Buffer.byteLength(String(n)) + currentFileData.length,
+  
+                         buffer.length);
+  
+    })
+  
+    .catch(throwNextTick);
+  
+}
 // test that appendFile accepts file descriptors
 const filename5 = join(tmpdir.path, 'append5.txt');
@@ -191,8 +213,7 @@ assert.throws(
  { code: 'ERR_INVALID_CALLBACK' });
 process.on('exit', function() {
-  
-  assert.strictEqual(ncallbacks, 6);
+  
+  assert.strictEqual(ncallbacks, 4);
-  
-  fs.unlinkSync(filename4);
  fs.unlinkSync(filename5);
 });