Add ArrayBuffer::Detach() and ::IsDetached() #659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that |
|
@tniessen do you need any more info to progress this? |
|
@tniessen are you still planning to work on this? |
|
Yes, sorry @mhdawson, I do intend to work on this. I didn't find much time recently. |
|
@tniessen np, just wanted to check in as I was doing some cleanup on the issues. |
|
@tniessen ping. |
|
Sorry it took me so long to get back to this! |
|
Looks good landing |
mhdawson
added a commit
that referenced
this issue
Nov 5, 2020
Refs: nodejs/node#29768 Refs: nodejs/node#30613 PR-URL: #659 Refs: nodejs/node#29768 Refs: nodejs/node#30613 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
|
Landed as c9563ca |
Superlokkus
added a commit
to Superlokkus/node-addon-api
that referenced
this issue
Nov 20, 2020
Refs: nodejs/node#29768 Refs: nodejs/node#30613 PR-URL: nodejs#659 Refs: nodejs/node#29768 Refs: nodejs/node#30613 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I don't know what the proper guard is, seems like
NAPI_EXPERIMENTALandNAPI_VERSIONare not good enough.Refs: nodejs/node#29768
Refs: nodejs/node#30613