This repository has been archived by the owner. It is now read-only.
Team 7 #2
Open
Team 7 #2
Conversation
Fix Pipfile dependencies
Exclude virtualenv from Flake8 linting. Again.
|
No commits yet? Hmm. |
|
No commits? Did you forget to push? |
| """ | ||
|
|
||
|
|
||
| async def get_json(url): |
jb3
Mar 25, 2018
Member
Why not json.loads inside this function so that you don't have to repeat code in future usages of this function?
Why not json.loads inside this function so that you don't have to repeat code in future usages of this function?
mushydev
Mar 25, 2018
Author
Done.
Done.
bot/cogs/snakes.py
Outdated
| if name in WikiListener.get_all_snek(): | ||
| return True | ||
| else: | ||
| return False | ||
|
|
||
| @command() | ||
| async def get(self, ctx: Context, name: str = None): |
jb3
Mar 25, 2018
Member
You should add some documentation to the command using docstrings.
@command
async def get(...):
"""Command info here"""
...
You should add some documentation to the command using docstrings.
@command
async def get(...):
"""Command info here"""
...
bot/cogs/snakes.py
Outdated
| This should make use of your `get_snek` method, using it to get information about a snake. This information | ||
| should be sent back to Discord in an embed. | ||
| quemoji = ['🇦', '🇧', '🇨', '🇩'] | ||
| question = ['Which snek is the sneakiest snek?', '🇦Cobra\n\n🇧Regular Snek\n\n🇨Python\n\n🇩<Cobra></Cobra>', '🇨'] |
jb3
Mar 25, 2018
Member
Any reason for Cobra being in < and >?
Any reason for Cobra being in < and >?
necatican
Mar 25, 2018
No reason at all. I am still testing the features the questions will be in a seperate file. Probably json.
No reason at all. I am still testing the features the questions will be in a seperate file. Probably json.
.vscode/settings.json
Outdated
| @@ -0,0 +1,6 @@ | |||
| { | |||
jb3
Mar 25, 2018
Member
Don't think this file should be here...
Don't think this file should be here...
mushydev
Mar 25, 2018
Author
Yeah, accident. Deleted now.
Yeah, accident. Deleted now.
[UPDATE] Ignored a silly rule from flake8.
|
You code is failing to lint. Please see Travis for more information. |
lemonsaurus
added a commit
to python-discord/bot
that referenced
this pull request
May 10, 2018
…g. (#74) Original PR: python-discord/code-jam-1#2 Completes task: https://app.clickup.com/754996/757069/t/2ww7u
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.