★ wanayoo — archive 1999 https://github.com/python-discord/code-jam-1/pull/2Nouvelle recherche | Portail wanayoo
Skip to content
This repository has been archived by the owner. It is now read-only.

Team 7 #2

Open
wants to merge 19 commits into
base: master
from
Open

Team 7 #2

wants to merge 19 commits into from

Conversation

@mushydev
Copy link

@mushydev mushydev commented Mar 23, 2018

No description provided.

mushfikurr and others added 3 commits Mar 23, 2018
Fix Pipfile dependencies
Exclude virtualenv from Flake8 linting. Again.
@lemonsaurus
Copy link
Member

@lemonsaurus lemonsaurus commented Mar 25, 2018

No commits yet? Hmm.

Copy link
Contributor

@gdude2002 gdude2002 left a comment

No commits? Did you forget to push?

mushfikurr and others added 4 commits Mar 25, 2018
Cardiumm
Cardiumm
"""


async def get_json(url):

This comment has been minimized.

@jb3

jb3 Mar 25, 2018
Member

Why not json.loads inside this function so that you don't have to repeat code in future usages of this function?

This comment has been minimized.

if name in WikiListener.get_all_snek():
return True
else:
return False

@command()
async def get(self, ctx: Context, name: str = None):

This comment has been minimized.

@jb3

jb3 Mar 25, 2018
Member

You should add some documentation to the command using docstrings.

@command
async def get(...):
    """Command info here"""
    ...
This should make use of your `get_snek` method, using it to get information about a snake. This information
should be sent back to Discord in an embed.
quemoji = ['🇦', '🇧', '🇨', '🇩']
question = ['Which snek is the sneakiest snek?', '🇦Cobra\n\n🇧Regular Snek\n\n🇨Python\n\n🇩<Cobra></Cobra>', '🇨']

This comment has been minimized.

@jb3

jb3 Mar 25, 2018
Member

Any reason for Cobra being in < and >?

This comment has been minimized.

@necatican

necatican Mar 25, 2018

No reason at all. I am still testing the features the questions will be in a seperate file. Probably json.

@@ -0,0 +1,6 @@
{

This comment has been minimized.

@jb3

jb3 Mar 25, 2018
Member

Don't think this file should be here...

This comment has been minimized.

@mushydev

mushydev Mar 25, 2018
Author

Yeah, accident. Deleted now.

mushfikurr and others added 7 commits Mar 25, 2018
[UPDATE] Ignored a silly rule from flake8.
@gdude2002
Copy link
Contributor

@gdude2002 gdude2002 commented Mar 25, 2018

You code is failing to lint. Please see Travis for more information.

mushfikurr and others added 5 commits Mar 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.