★ wanayoo — archive 1999 https://github.com/pythonicrubyist/creek/issues/80Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove http dependency? #80

Closed
fanfilmu opened this issue Apr 23, 2019 · 1 comment
Closed

Remove http dependency? #80

fanfilmu opened this issue Apr 23, 2019 · 1 comment

Comments

@fanfilmu
Copy link

@fanfilmu fanfilmu commented Apr 23, 2019

Hello!

I would like to propose removing the http gem dependency entirely. From what I see, it's only used to download remote XLSX files, which, in my opinion, should be handled outside the gem by the devs (by their favourite http gem with 10 monkeypatches for their own super-secret security policy :) ).

Benefits that I see:

  • does not require to download a lib which has tons of alternatives
  • does not require users to update the lib to match Creek dependency
  • prevents clashes with other gems depending on HTTP

Personally, it would allow me to update Creek without regenerating VCRs and solving problems that come with it... 😇

Let me know what you think!

@mdavidn
Copy link

@mdavidn mdavidn commented Jun 11, 2019

Yes, please. The http gem brings six transitive dependencies, including one native extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.