★ wanayoo — archive 1999 https://github.com/security-code-scan/security-code-scan/issues/54Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuration file schema changes and multiple SCS installations #54

Open
JarLob opened this issue Jun 5, 2018 · 0 comments
Open
Labels

Comments

@JarLob
Copy link
Contributor

@JarLob JarLob commented Jun 5, 2018

A continuation of #15

There may be incompatible changes in configuration schema between versions. To support that:

  1. A configuration file should has a property Version. It is better to have it as a property instead of filename, because configuration files may be per projects.
  2. The version number should be separate from assembly version because there may be no configuration schema changes between different SCS versions.
  3. When SCS is updated it should attempt to (an investigation is needed what is possible):
    • update the config in AppData in VS extension case. Since the location is shared between different installations (vs2015, vs2017 and nugets) the upgrade should create a new file in the folder (version number in the file name).
    • update the config in project when NuGet package is updated or during analysis in VS extension case (Investigate if it is even possible to have two versions of SCS running from NuGet and from VS extension at the same time. If it is, then maybe VS extension should convert the config in memory on the fly only).
  4. If upgrade has failed or the version number is newer than supported SCS should show a fake analysis warning (SCS_Error1?) when the analysis is kicked off.
    • SCS_Warning for a suggestion to upgrade when doing memory only upgrade?
    • Since a user may change the number manually or the file maybe corrupted SCS_Error is needed if an exception happened during config loading.
@JarLob JarLob added the enhancement label Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.