★ wanayoo — archive 1999 https://github.com/trustar/trustar-python/issues/50Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-required id and id_type parameters to this function call. #50

Open
stevenchamales opened this issue Feb 23, 2019 · 0 comments
Open
Assignees

Comments

@stevenchamales
Copy link
Collaborator

@stevenchamales stevenchamales commented Feb 23, 2019

def update_report(self, report):

Functions should do what they're told, and do as little inference / assumption as possible. The user should specify which ID and ID type they want to use to update the report. There should be no ambiguity at all.

Make these params optional, for backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.