★ wanayoo — archive 1999 https://github.com/xtensor-stack/xtensor/pull/1565Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In tests, include the primary header first. #1565

Open
wants to merge 1 commit into
base: master
from

Conversation

@laramiel
Copy link

@laramiel laramiel commented May 2, 2019

Pull request based on some minor cleanups from #1476

This basically follows the include-what-you-use philosophy which also includes the .h file as the primary file in tests. Additionally:

  • Adds missing <type_info> include uncovered by this reordering.
  • Fixes memory leak in test by using std::unique_ptr.

(I will be splitting some of the rest of that pull request up into smaller pieces)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.