Standardize xtensor_type_caster_base signature #234

AntoinePrv · 2020-03-06T15:32:25Z

Hello,
I wonder if there is a reason why the xtensor_type_caster_base uses xt::xtensor for the signature

Line 161 in 719b9d1

static constexpr auto name = _("xt::xtensor");

instead of using numpy.ndarray[...]

Line 72 in 719b9d1

    
           PYBIND11_TYPE_CASTER(type, _("numpy.ndarray[") + npy_format_descriptor<T>::name + _("]"));

In my opinion, using the Numpy name is more descriptive to a Python user, and actually matches the type.

I made a quick test using

_("numpy.ndarray[") + npy_format_descriptor<typename Type::value_type>::name + _("]");

which seems to work.

I could send a PR if you are interested.

Thank you

JohanMabille · 2020-03-12T22:20:23Z

Good question! Honestly, I don't remember the why of this decision. @SylvainCorlay @wolfv any idea?

xtensor-stack / xtensor-python