Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upREADME: Replace deserialize eval with JSON.parse #38
Conversation
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! |
This updates README.md to suggest using [JSON.parse](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse) instead of eval to address security concerns.
|
But isn't the serialization of complex objects the main purpose of this utility? So being able to deserialize it in the same way seems to be a plausible cause for the @unlobito you're right that this is dangerous and the warning sign should be huge. |
|
Selamlar, bu benim için güvenlik açıklarıma faydalı olacaktır, eğer kısmen eksik yönlerim olursa değerlendireceğim |
|
Herkese selamlar, kiwiirc için JavaScript doğrulaması için bunu kullanıyorum, eğer bilmem gereken şeyler varsa lütfen iletin |
From json.org:
This updates README.md to suggest using JSON.parse instead.