★ wanayoo — archive 1999 https://github.com/MagicStack/uvloop/pull/337Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't stop the loop in `run_until_complete()` on `SystemExit` and `KeyboardInterrupt` exceptions #337

Open
wants to merge 2 commits into
base: master
from

Conversation

@jack1142
Copy link
Contributor

jack1142 commented Apr 24, 2020

Fixes #336

@1st1
Copy link
Member

1st1 commented May 13, 2020

Can you add a unittest?

@jack1142 jack1142 force-pushed the jack1142:patch-1 branch from 5df6193 to b762e9a May 15, 2020
@jack1142
Copy link
Contributor Author

jack1142 commented May 15, 2020

@1st1 I added the unit test based on CPython's equivalent and rebased the PR's branch on top of master.
Let me know if there's anything else you would want me to do.

@jack1142 jack1142 force-pushed the jack1142:patch-1 branch from b762e9a to 9e78c4e May 19, 2020
jack1142 and others added 2 commits Apr 24, 2020
…errupt
Co-authored-by: Victor Stinner <victor.stinner@gmail.com>
@jack1142 jack1142 force-pushed the jack1142:patch-1 branch from 9e78c4e to 8d35920 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.