Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[NEW] Project 09 - Recording and sending audio VoiceOver accessible #2748
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2748 +/- ##
===========================================
- Coverage 46.1% 45.04% -1.07%
===========================================
Files 626 626
Lines 28938 28953 +15
===========================================
- Hits 13343 13042 -301
- Misses 15595 15911 +316
Continue to review full report at Codecov.
|
|
@rudrankriyam You did a really great work on this PR! The only thing that wasn't working was the duration slider. It still says "0% adjustable". And maybe you wanna bring those changes over to the audio player in chat as well. |
|
Awesome work. Thank you! |
| progressSlider.setValue(progressSlider.value - 10, animated: true) | ||
| valueUpdated() | ||
| } | ||
| } |
houndci-bot
Aug 19, 2019
File Line Length Violation: File should contain 400 lines or less: currently contains 449 (file_length)
File Line Length Violation: File should contain 400 lines or less: currently contains 449 (file_length)
| @@ -397,3 +420,30 @@ extension AudioView { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| // MARK: Accessibility | |||
houndci-bot
Aug 19, 2019
Mark Violation: MARK comment should be in valid format. e.g. '// MARK: ...' or '// MARK: - ...' (mark)
Mark Violation: MARK comment should be in valid format. e.g. '// MARK: ...' or '// MARK: - ...' (mark)
| self.timeLabel.text = displayFormat | ||
| self.timeLabel.accessibilityLabel = ComposerView.localized(.durationLabel) + self.timeDuration(displayTime) | ||
|
|
||
| self.progressSlider.accessibilityValue = ComposerView.localized(.sliderLabelPosition) + self.timeDuration(Int(player.currentTime)) |
houndci-bot
Aug 19, 2019
Line Length Violation: Line should be 120 characters or less: currently 142 characters (line_length)
Line Length Violation: Line should be 120 characters or less: currently 142 characters (line_length)
@RocketChat/ios
The following buttons are described in VoiceOver with a redundant “Button”
I hid the accessibilityElements wherever applicable so it provides a smooth VoiceOver experience.