Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSiemens interfile #135
Siemens interfile #135
Conversation
|
I've added the easy keys. I need help to process the hard ones
|
- removed most keywords from InterfileHeaderSiemens that were already in InterfileHeader - had to create a MinimalInterfileHeader class as there is a clash in the duration keywords between STIR and Siemens Interfile - read much more, and initialise a ProjDataInfo object correctly things to do: - I get a memory error at the end of running list_projdata_info - actual reading of segment-order etc hasn't been done yet. - various bits marked with XXX
- inserted segment_sequence - fix post_processing still a few XXXX and the sme memory error (probably ZZdeallocation of image_durations)
- fixed timing keyword type - added energy window parsing - added check on compression TODO: - expand to listmode, norm and images
|
@paskino, this should now work ok. we'll need to start on listmode... |
|
@paskino, possibly you could some more innocent keys, such that we don't get all the warnings? Could give them a no-op action at the moment. |
|
will do |
|
ok. possibly ready now :-; Most unparsed keywords should go in
And here are those for the
again, use a no_op for now. add_key("keyword" , KeyArgument::NONE, &KeyParser::do_nothing); |
|
@evgueni-ovtchinnikov could you try this with the original header (not the |
|
for future reference: the listmode header does not contain the following
These are nevertheless initialised/checked in |
|
I'm not sure if norm files need a change. Please try. It might be that |
|
gcc on Travis complains as follows
This is despite class PatientPosition
{
public:
//! enum specifying if the patient is scanned with the head first in the gantry, or the feet.
enum OrientationValue
{ head_in, feet_in, other_orientation, unknown_orientation };
//! enum specifying on what side the patient is lying on
/*! \a prone is face-downward, \a left is lying on the left side */
enum RotationValue
{ supine, prone, right, left, other_rotation, unknown_rotation };
//! enum using DICOM abreviations
/*! See Dicom C.7.3.1.1.2 */
enum PositionValue
{
HFS, //!< Head First-Supine
<snip>
unknown_position
};Clang is happy with this, so is Visual Studio 2015. Anyone any ideas? |
|
listmode_to_sinograms.py works fine with list.l.hdr (still lots of warnings though) |
|
as_ecat8.py also works fine with norm.n.hdr (had to correct line endings since I am on Windows) |
|
list of keywords for the PDFS that need to be parsed. The study date ones are interesting. It seems that the KeyParser truncates
due to the :. That seems a bug. Might not be easy to fix so I think it needs a separate issue.
|
|
List for listmode. Large overlap with the PDFS ones, so the overlapping ones have to be in RawData as mentioned above.
|
|
@evgueni-ovtchinnikov, neither |
|
No idea. What are your input files? |
|
blank (default) |
|
@rijobro I presume you are running SIRF on Mac? Everything works fine on Windows/CentOS/Ubuntu. |
|
I had a problem that was due to the example files ( I then came across other problems that @KrisThielemans managed to sort out. We can have a look at the code on Friday if you want. |
|
Current code will segfault when using a converted hdr for a listmode file. Reason is that the |
|
New issues created #149 and #148 for things noted above. Will fix those in separate PRs. I think that means the things that need doing here
|
|
thanks. can you do the other 2 items on the checklist? then we merge |
|
by the way, I intend to squash-merge this (unless somebody volunteers to clean up the history) |
updated release info 3.1 updated bash script for Siemens interfile
|
I wouldn't quite know where to put info in the user's guide. I've ticked the checklist |
…ormat
paskino commentedJan 12, 2018
•
edited
This is a WORK IN PROGRESS PR.
The siemens interfile reader now is called when the parser finds the specific field
%sms-mi version numberin the header.