Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Codeception allure adapter conflicting with PHPUnit allure adapter #44
Comments
okolesnyk
added a commit
to okolesnyk/allure-codeception
that referenced
this issue
Dec 12, 2018
- Codeception allure adapter conflicting with PHPUnit allure adapter
|
Thank you for submitting PR for this issue! |
okolesnyk
added a commit
to okolesnyk/allure-codeception
that referenced
this issue
Dec 18, 2018
- Codeception allure adapter conflicting with PHPUnit allure adapter - Code review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
If any project will require two allure-framework packages (in our case allure-phpunit and allure-codeception) we will have two classes which have identical full class names:
Yandex\Allure\Adapter\AllureAdapter.It will cause an issue for autoloader to load appropriate adaptor for codeception and phpunit.
Suggestion
Make namespace unique.
For example:
Yandex\Allure\Codeception\Adapter\AllureAdapterYandex\Allure\PHPUnit\Adapter\AllureAdapterOr class name unique
Yandex\Allure\Adapter\CodeceptionAllureAdapterYandex\Allure\Adapter\PHPUnitAllureAdapterRelated Issue
allure-framework/allure-phpunit#41