Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Allow configurable page source in AllureSelenide #394
Conversation
|
|
803db1f
to
df89f35
df89f35
to
c5d9c55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Context
I need to be able to configure page source for attachments in AllureSelenide. I use appium for automation of native mobile applications. On getPageSource() request Appium returns XML tree by default (and it can also be configured to return JSON), not HTML like Selenium WebDriver. So when my XML is treated as HTML, attachment is not displayed in Allure. It's just blank (because of source type mismatch).
So my pull request fixes this issue. By default HTML source type is implied but client can configure it to their needs using
configureSource()method.Checklist