Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Reuse Selenide screenshots #440
Conversation
| @@ -91,10 +95,24 @@ public AllureSelenide disableLogs(final LogType logType) { | |||
| } | |||
|
|
|||
| private static Optional<byte[]> getScreenshotBytes() { | |||
| return ScreenShotLaboratory.getInstance().getLastThreadScreenshot() | |||
baev
Jun 5, 2020
Member
what if you are using saveScreenshots=true and make a single screenshot manually at test start? It seems like you'll get the same screenshot in all the steps
what if you are using saveScreenshots=true and make a single screenshot manually at test start? It seems like you'll get the same screenshot in all the steps
dstekanov
Jun 16, 2020
Author
Contributor
If I understand correctly, it should not be a case because Selenide will take a separate screenshot on each fail
If I understand correctly, it should not be a case because Selenide will take a separate screenshot on each fail
SeleniumTestAB
Jul 11, 2020
@dstekanov and what if we got a case, when someone manually produces a screenshot on fail to attach it to the Main Test Result Page and not under the steps, while also wanting that screenshot to be under given step? Also what if we use Junit assertAll with selenide boolean methods?
@dstekanov and what if we got a case, when someone manually produces a screenshot on fail to attach it to the Main Test Result Page and not under the steps, while also wanting that screenshot to be under given step? Also what if we use Junit assertAll with selenide boolean methods?
|
Sorry, it was just a test. |
Context
The idea behind it is to not take screenshot 2 times (by Selenide and by Allure) but check if Selenide has already taken one and re-use it otherwise take a new screenshot.
Selenide issue history selenide/selenide#1002
Checklist