★ wanayoo — archive 1999 https://github.com/allure-framework/allure2/pull/487Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show attachments in modal view #487

Merged
merged 11 commits into from Jul 26, 2017
Merged

Show attachments in modal view #487

merged 11 commits into from Jul 26, 2017

Conversation

@sseliverstov
Copy link
Member

sseliverstov commented Jul 21, 2017

//: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)

Context

Checklist

@sseliverstov sseliverstov requested review from baev and just-boris Jul 21, 2017
if (attachment) {
this.routeState.set('attachment', attachment);
} else {
this.routeState.unset('attachment', {silent: true});

This comment has been minimized.

@just-boris

just-boris Jul 23, 2017

Member

Silent is usually an anti-pattern. Can you not to use this option?

This comment has been minimized.

@just-boris

just-boris Jul 23, 2017

Member

You can add a check into highlightSelectedAttachment method instead.

@just-boris
Copy link
Member

just-boris commented Jul 23, 2017

Visual review

image

image

I don't like the current inline display. My suggestion

image

@just-boris
Copy link
Member

just-boris commented Jul 23, 2017

And my constant reminder about tab content: Steps should be on the first tab. I think this change should be done the first, before all other improvements with inline attachments.

@sseliverstov
Copy link
Member Author

sseliverstov commented Jul 24, 2017

@just-boris
I am not sure that it is finally variant of layout for steps attachments. Your suggestion is interesting to, but in this iteration i save curent view.

@just-boris
Copy link
Member

just-boris commented Jul 24, 2017 •

  • We have never used this blue color for borders. It just looks like 💩 . I tried to save it as much as I could.
  • Modal still doesn't close if you will click on the place bellow the modal
@sseliverstov
Copy link
Member Author

sseliverstov commented Jul 24, 2017

2017-07-24 17 55 36

@just-boris how about this?
@sseliverstov
Copy link
Member Author

sseliverstov commented Jul 24, 2017

2017-07-24 18 55 36

@sseliverstov
Copy link
Member Author

sseliverstov commented Jul 25, 2017

@just-boris i am done

@baev
baev approved these changes Jul 26, 2017
@baev baev merged commit 73b8847 into master Jul 26, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@baev baev deleted the attachments-modal-view branch Jul 26, 2017
@baev baev removed work:review labels Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.