New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(bazel): Turning on strictPropertyInitialization for Angular. #24572
Conversation
|
Waiting to hear from Martin on why does clang-format decided to do 'foo !: string', instead of 'foo!: string', which is way better IMHO. |
|
You can preview 1d78a8f at https://pr24572-1d78a8f.ngbuilds.io/. |
|
According to @mprobst, it's just an outdated version of clang-format. The travis failures look like flakes to me, because this cl has no observable runtime change. |
|
@alxhub There seems to be some weird interaction between this PR and |
|
@alxhub The extra '!' have no runtime implications, but it is possible that the syntax throws off the new transformers. |
|
You can preview f596feb at https://pr24572-f596feb.ngbuilds.io/. |
|
AlexR and I sorted out the ivy failures, PTAL |
All errors for existing fields have been detected and suppressed with a `!` assertion. Issue/24571 is tracking proper clean up of those instances. One-line change required in ivy/compilation.ts, because it appears that the new syntax causes tsickle emitted node to no longer track their original sourceFiles.
|
You can preview 3175a43 at https://pr24572-3175a43.ngbuilds.io/. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
All errors for existing fields have been detected and suppressed with a
!assertion.Issue #24571 is tracking proper clean up of those instances.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The text was updated successfully, but these errors were encountered: