★ wanayoo — archive 1999 https://github.com/angular/angular/pull/24572Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bazel): Turning on strictPropertyInitialization for Angular. #24572

Closed
wants to merge 1 commit into from

Conversation

@rkirov
Copy link
Contributor

@rkirov rkirov commented Jun 19, 2018 •

All errors for existing fields have been detected and suppressed with a
! assertion.

Issue #24571 is tracking proper clean up of those instances.

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No
@rkirov rkirov requested a review from mhevery Jun 19, 2018
@rkirov
Copy link
Contributor Author

@rkirov rkirov commented Jun 19, 2018

Waiting to hear from Martin on why does clang-format decided to do 'foo !: string', instead of 'foo!: string', which is way better IMHO.

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Jun 19, 2018

@rkirov
Copy link
Contributor Author

@rkirov rkirov commented Jun 20, 2018

According to @mprobst, it's just an outdated version of clang-format.

The travis failures look like flakes to me, because this cl has no observable runtime change.

@mhevery
Copy link
Contributor

@mhevery mhevery commented Jun 20, 2018

@mhevery
Copy link
Contributor

@mhevery mhevery commented Jun 20, 2018

@alxhub There seems to be some weird interaction between this PR and ngtsc could you have a look?

@rkirov
Copy link
Contributor Author

@rkirov rkirov commented Jun 21, 2018

@alxhub The extra '!' have no runtime implications, but it is possible that the syntax throws off the new transformers.

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Jun 22, 2018

@rkirov
Copy link
Contributor Author

@rkirov rkirov commented Jun 22, 2018

AlexR and I sorted out the ivy failures, PTAL

All errors for existing fields have been detected and suppressed with a
`!` assertion.

Issue/24571 is tracking proper clean up of those instances.

One-line change required in ivy/compilation.ts, because it appears that
the new syntax causes tsickle emitted node to no longer track their
original sourceFiles.
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Jun 22, 2018

@mhevery mhevery closed this in c95437f Jun 25, 2018
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants