Generate correct sourceMapUrl #38
Open
Conversation
|
Sorry for the delay in looking at this. Can you please fix these minor lint errors? Also can you please provide before and after example output for the SourceMapUrl? |
| @@ -13,6 +14,10 @@ export class JSBuilder { | |||
| let mainModule = this._buildMainModule(data.dependencies._mainModule); | |||
| let raw = data.files.js.map(path => fse.readFileSync(path).toString()).join('\n'); | |||
Splaktar
May 10, 2019
Member
path here now causes a lint error:
ERROR: /home/travis/build/angular/material-tools/lib/builders/JSBuilder.ts[15, 33]: Shadowed name: 'path'
Can you please rename this path variable to file?
path here now causes a lint error:
ERROR: /home/travis/build/angular/material-tools/lib/builders/JSBuilder.ts[15, 33]: Shadowed name: 'path'Can you please rename this path variable to file?
| @@ -13,6 +14,10 @@ export class JSBuilder { | |||
| let mainModule = this._buildMainModule(data.dependencies._mainModule); | |||
| let raw = data.files.js.map(path => fse.readFileSync(path).toString()).join('\n'); | |||
| let source = [mainModule, '', raw].join('\n'); | |||
|
|
|||
| // Create source map filename from given minified filename | |||
| filename = path.basename(filename).replace(/\.min\.js/, '.map') | |||
Splaktar
May 10, 2019
Member
This is causing a lint error:
ERROR: /home/travis/build/angular/material-tools/lib/builders/JSBuilder.ts[19, 68]: Missing semicolon
This is causing a lint error:
ERROR: /home/travis/build/angular/material-tools/lib/builders/JSBuilder.ts[19, 68]: Missing semicolon|
Just wanted to drop a note here to remind you that there are some outstanding changes needed to this PR before we can merge it. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
All minified files are created with an invalid
sourceMapUrlpath. I.e. instead of a relativefile.mapit uses an absolute local file path likepath/on/my/disk/to/file.min.js.Browsers then complain about the invalid source map and actually reveal the local path in the dev console (!)