★ wanayoo — archive 1999 https://github.com/apache/airflow/pull/9699Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeSensor should consider the default_timezone config #9699

Merged
merged 2 commits into from Jul 18, 2020

Conversation

@22quinn
Copy link
Contributor

@22quinn 22quinn commented Jul 6, 2020

Fixes #9609


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

kaxil
kaxil approved these changes Jul 17, 2020
Copy link
Member

@kaxil kaxil left a comment

Can you please rebase on the master branch to remove conflicts?

@22quinn 22quinn force-pushed the time-sensor-timezone branch from b754a8b to b88cd95 Jul 18, 2020
@22quinn
Copy link
Contributor Author

@22quinn 22quinn commented Jul 18, 2020

Can you please rebase on the master branch to remove conflicts?

Done. Thanks for the review.

Do you mind also taking a look at #9697? It offers idempotence for target_time.

@kaxil kaxil merged commit b34ba87 into apache:master Jul 18, 2020
29 of 30 checks passed
@22quinn 22quinn deleted the time-sensor-timezone branch Jul 19, 2020
@freget
Copy link
Contributor

@freget freget commented Jul 19, 2020

Cool, thank you!

@wangze999999
Copy link

@wangze999999 wangze999999 commented Jul 19, 2020

@JeffryMAC
Copy link

@JeffryMAC JeffryMAC commented Jul 19, 2020

I have two questions:

  1. When this is released?
  2. If someone is writing timezone aware dag. it might be very confusing when the TimeSensor works with default setting that can't be change. I think to make this change complete maybe it should take first the Timezone from Dag if given otherwise the default from the airflow settings.

@22quinn
Copy link
Contributor Author

@22quinn 22quinn commented Jul 19, 2020

2. If someone is writing timezone aware dag. it might be very confusing when the TimeSensor works with default setting that can't be change. I think to make this change complete maybe it should take first the Timezone from Dag if given otherwise the default from the airflow settings.

Good point. I was not aware of the existence of timezone-aware dags. Just created another PR to achieve this: #9882

@kaxil kaxil added this to the Airflow 1.10.13 milestone Aug 26, 2020
kaxil added a commit that referenced this issue Nov 20, 2020
kaxil added a commit that referenced this issue Nov 20, 2020
kaxil added a commit that referenced this issue Nov 20, 2020
kaxil added a commit that referenced this issue Nov 20, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this issue Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants