This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fixes #209: CLI option for number of CPUs when creating a new boot2docker VM #341
Conversation
|
@SvenDowideit @steeve If this looks good, can we please merge this one ? Also, I would recommend having a similar feature in docker-compose. |
config.go
Outdated
| @@ -116,6 +116,7 @@ func config() (*flag.FlagSet, error) { | |||
| flags.StringVar(&B2D.SSHKey, "sshkey", filepath.Join(sshdir, "id_boot2docker"), "path to SSH key to use.") | |||
| flags.UintVarP(&B2D.DiskSize, "disksize", "s", 20000, "boot2docker disk image size (in MB).") | |||
| flags.UintVarP(&B2D.Memory, "memory", "m", 2048, "virtual machine memory size (in MB).") | |||
| flags.UintVarP(&B2D.CPUs, "cpus", "c", 1, "number of cpus for boot2docker.") | |||
tianon
Feb 11, 2015
Contributor
Shouldn't this default to runtime.NumCPU()?
Shouldn't this default to runtime.NumCPU()?
tianon
Feb 11, 2015
Contributor
Also, cpus in the help text should probably be CPUs instead.
Also, cpus in the help text should probably be CPUs instead.
|
Okay, I have addressed your comments. |
|
LGTM cc @gmlewis @Moghedrin |
This comment has been minimized.
This comment has been minimized.
|
LGTM but will let someone else merge and close. |
tianon
added a commit
that referenced
this pull request
Feb 24, 2015
Fixes #209: CLI option for number of CPUs when creating a new boot2docker VM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This pull request enhances boot2docker init by allowing user to pass --cpus to configure the number of cpus allocated to boot2docker-vm during vm creation.