★ wanayoo — archive 1999 https://github.com/catherinedevlin/ipython-sql/pull/42Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for Jupyter 4 #42

Open
wants to merge 6 commits into
base: master
from
Open

update for Jupyter 4 #42

wants to merge 6 commits into from

Conversation

@mccahill
Copy link

mccahill commented Sep 14, 2015

When running under iPython4 (Jupyter) there are warnings about deprecated calls when calling load_ext sql

/opt/conda/lib/python3.4/site-packages/IPython/config.py:13: ShimWarning: The `IPython.config` package has been deprecated. You should import from traitlets.config instead.
  "You should import from traitlets.config instead.", ShimWarning)
/opt/conda/lib/python3.4/site-packages/IPython/utils/traitlets.py:5: UserWarning: IPython.utils.traitlets has moved to a top-level traitlets package.
  warn("IPython.utils.traitlets has moved to a top-level traitlets package.")

This commit fixes that, and also gets around the ascii character set problems in reading in the README and NEWS files when compiling.

Signed-off-by: Mark McCahill mark.mccahill@duke.edu

get rid of the traitlets warnings

Signed-off-by: Mark McCahill <mark.mccahill@duke.edu>
Signed-off-by: Mark McCahill <mark.mccahill@duke.edu>
For student use, default the limits for rows returned (100000) and rows displayed (1000) to sizes that will not crash their web browser or pound the SQL server.  You can still reset the limits if you
want, but this raises the barrier to shooting yourself in the foot.

Signed-off-by: Mark McCahill <mark.mccahill@duke.edu>
@yuvipanda
Copy link

yuvipanda commented Dec 10, 2015

poke anyone?

@yuvipanda
Copy link

yuvipanda commented Dec 16, 2015

This PR seems to be doing 3 somewhat unrelated things...

@catherinedevlin
Copy link
Owner

catherinedevlin commented Mar 4, 2016

My huge apologies - I had GitHub notifications misconfigured, and 4 (!) different people submitted this same enhancement. I merged #50, since it included the test file.

I'll investigate the other changes in your PR as soon as I can. Thanks so much!

@matthiasroder
Copy link

matthiasroder commented Jun 2, 2016

Why is this not getting merged?

@romanchyla
Copy link

romanchyla commented Aug 21, 2016

Hi Catherine, your extension is really great. Thank you!

Please see ifyou can find a moment to apply this PR. The warning doesn't look very nice in the notebook

mccahill added 3 commits Dec 9, 2016
Signed-off-by: Mark McCahill <mark.mccahill@duke.edu>
Signed-off-by: Mark McCahill <mark.mccahill@duke.edu>
@zebralight
Copy link

zebralight commented Jun 24, 2017

I was wondering how to install this particular branch. Will I need to compile it from source myself? Or can I simply run setup.py?

@gcbeltramini
Copy link

gcbeltramini commented Nov 27, 2017 •

@zebralight, to install this version:

$ pip install git+git://github.com/mccahill/ipython-sql.git
@kavisek
kavisek approved these changes Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.