Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcall __repr__() on url rather than __str__() to hide password #94
Conversation
|
Since sqlite does not use a password in the connection string we can't test this under the current set up AFAIK. is there an interest in setting up a testing environment with CircleCI or something similar so we can easily run tests against postgres? |
|
also: for some reason the connection string is sometimes printed out more than once. I am looking into this. |
|
it looks like the culprit is in
Here it looks like we are mapping the connection's assigned name and its url to the the |
|
Ah, I semi-remember now: the idea was that you'd be able to refer to a connection either by its full connection string, or by an abbreviated version. That way you could use `In [5]: %sql postgresql://passwordy:password@/catherine In [6]: %sql sqlite:///mydb.sqlite In [7]: %sql
In [8]: %sql passwordy@catherine Can we maintain that capability? |
|
gotcha, so I guess we're good with that |
calling it during connection_list causes the shortened connection name (like user@mydb) to not be displayed
|
do you have any thoughts on how to test for this fix? (see above) |
jstoebel commentedJul 30, 2017
•
edited
calling
__repr__()rather than__str__()on the connection url object hides the password.this should close #91