Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Export RequestInit interface #121
Merged
Conversation
|
The types we can certainly do, but I don't think we can export RequestInit itself. |
| @@ -2,14 +2,16 @@ import { | |||
| Body as NodeBody, | |||
| Headers as NodeHeaders, | |||
| Request as NodeRequest, | |||
| Response as NodeResponse | |||
| Response as NodeResponse, | |||
| RequestInit as NodeRequestInit | |||
developit
Feb 18, 2020
Owner
unfetch doesn't support RequestInit, so exporting this from isomorphic-unfetch makes the interfaces incompatible depending on environment.
unfetch doesn't support RequestInit, so exporting this from isomorphic-unfetch makes the interfaces incompatible depending on environment.
0x80
Feb 26, 2020
Author
Contributor
Ah bummer. I guess close this PR then...
Ah bummer. I guess close this PR then...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Exports the RequestInit interface for use in client code like described here #120.