Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upthen-redis yarn warning #74
Comments
|
@maprules1000 it should definitely be possible but might be a bit of work. would you be interested in trying to submit a PR? I'm sure the ECD team is willing to help you out if you decide to do so. You can find us in the if you're busy no worries! We'll try to get to it soon anyway, it's been on the list for a long time.. |
|
Yup, I will find some time for it @ghedamat! |
replaces then-redis with redis. closes #74
Revert "replaces then-redis with redis. closes #74"
|
Unfortunately, I had to revert #74. While the tests passed (because the redis library is mocked in the tests), the plugin doesn't actually work. The methods in the |
Also, significantly reduce mocking in the test suite by using an in-memory redis client. Fixes ember-cli-deploy#51 Fixes ember-cli-deploy#74
Also, significantly reduce mocking in the test suite by using an in-memory redis client. Fixes ember-cli-deploy#51 Fixes ember-cli-deploy#74
|
See #86 |
When using yarn to manage packages it throws the following warning:
warning "then-redis@2.0.1" has unmet peer dependency "redis-commands@*".and the
then-redismaintainer has announced he is no longer maintainingthen-redisand that users should switch tonode_rediswhich now contains promise goodness.So, is it possible to drop
then-redisand replace it withnode_redis?