★ wanayoo — archive 1999 https://github.com/ember-cli-deploy/ember-cli-deploy-redis/issues/74Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

then-redis yarn warning #74

Closed
maprules1000 opened this issue Apr 13, 2017 · 4 comments
Closed

then-redis yarn warning #74

maprules1000 opened this issue Apr 13, 2017 · 4 comments
Labels

Comments

@maprules1000
Copy link
Contributor

@maprules1000 maprules1000 commented Apr 13, 2017

When using yarn to manage packages it throws the following warning:
warning "then-redis@2.0.1" has unmet peer dependency "redis-commands@*".

and the then-redis maintainer has announced he is no longer maintaining then-redis and that users should switch to node_redis which now contains promise goodness.

So, is it possible to drop then-redis and replace it with node_redis?

@ghedamat
Copy link
Contributor

@ghedamat ghedamat commented Apr 13, 2017 •

@maprules1000 it should definitely be possible but might be a bit of work.

would you be interested in trying to submit a PR? I'm sure the ECD team is willing to help you out if you decide to do so. You can find us in the ec-deploy channel of the ember-community slack.

if you're busy no worries! We'll try to get to it soon anyway, it's been on the list for a long time..

@maprules1000
Copy link
Contributor Author

@maprules1000 maprules1000 commented Apr 13, 2017

Yup, I will find some time for it @ghedamat!

@lukemelia lukemelia closed this in 05730f0 Apr 30, 2017
lukemelia added a commit that referenced this issue Apr 30, 2017
replaces then-redis with redis. closes #74
lukemelia added a commit that referenced this issue May 4, 2017
This reverts commit 05730f0.
lukemelia added a commit that referenced this issue May 4, 2017
Revert "replaces then-redis with redis. closes #74"
@lukemelia lukemelia reopened this May 4, 2017
@lukemelia
Copy link
Contributor

@lukemelia lukemelia commented May 4, 2017

Unfortunately, I had to revert #74. While the tests passed (because the redis library is mocked in the tests), the plugin doesn't actually work. The methods in the redis package's client implementation do not return promises, as they do in then-redis. Our code expects the return values to be promises. @maprules1000 or someone else will need to take another attempt at this.

blimmer added a commit to blimmer/ember-cli-deploy-redis that referenced this issue Aug 30, 2018
Also, significantly reduce mocking in the test suite by using an
in-memory redis client.
Fixes ember-cli-deploy#51
Fixes ember-cli-deploy#74
@blimmer blimmer mentioned this issue Aug 30, 2018
2 of 2 tasks complete
blimmer added a commit to blimmer/ember-cli-deploy-redis that referenced this issue Aug 30, 2018
Also, significantly reduce mocking in the test suite by using an
in-memory redis client.
Fixes ember-cli-deploy#51
Fixes ember-cli-deploy#74
@blimmer
Copy link
Contributor

@blimmer blimmer commented Aug 30, 2018

See #86

@ghedamat ghedamat closed this in #86 Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.