★ wanayoo — archive 1999 https://github.com/ev3dev-lang-java/ev3dev-lang-java/issues/498Nouvelle recherche | Portail wanayoo
Skip to content

/ ev3dev-lang-java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace innerclasses for a generic class to solve all scenarios for EV3 Sensors #498

Closed
jabrena opened this issue May 5, 2018 · 3 comments
Closed

Replace innerclasses for a generic class to solve all scenarios for EV3 Sensors #498

jabrena opened this issue May 5, 2018 · 3 comments
Assignees
@jabrena
Labels
Java UML design development refactoring resolved
Milestone
v0.9.0

Comments

@jabrena
Copy link
Member

@jabrena jabrena commented May 5, 2018 •
edited

It is necessary to design a solution to replace all inner classes used on EV3 Sensors for a simple inmutable class with a generic constructor.

This improvement, will reduce the complexity to understand the UML Class diagram
@jabrena jabrena added this to the v0.9.0 milestone May 5, 2018
@jabrena jabrena self-assigned this May 5, 2018
@jabrena
Copy link
Member Author

@jabrena jabrena commented May 5, 2018

https://jitpack.io/com/github/ev3dev-lang-java/ev3dev-lang-java/2.4.1-SNAPSHOT/build.log
jabrena added a commit that referenced this issue May 5, 2018
@jabrena
Merge branch 'feature/#443' into feature/#498
474358d
@jabrena
Copy link
Member Author

@jabrena jabrena commented May 5, 2018

Detail about StackTrace when any user disconnect a Sensor:

ev3dev#35|2018-05-05 17:10:09 [main] ERROR ev3dev.utils.Sysfs - Problem reading path: /sys/class/lego-sensor/sensor3/value0
ev3dev#35|java.io.IOException: Problem reading path: /sys/class/lego-sensor/sensor3/value0
ev3dev#35|	at ev3dev.utils.Sysfs.readString(Sysfs.java:74)
ev3dev#35|	at ev3dev.utils.Sysfs.readFloat(Sysfs.java:91)
ev3dev#35|	at ev3dev.sensors.GenericMode.fetchSample(GenericMode.java:63)
ev3dev#35|	at example.robotics.ev3.sensor.USSensorExample.main(USSensorExample.java:26)
@jabrena
Copy link
Member Author

@jabrena jabrena commented May 5, 2018

Fixed
@jabrena jabrena closed this May 5, 2018
@jabrena jabrena mentioned this issue Aug 13, 2018
Closed
jabrena added a commit that referenced this issue Oct 28, 2018
@jabrena
Merge branch 'feature/#443' into feature/#498
77d4f09 
# Conflicts:
#	build.gradle
#	docs/uml/graph.dot
#	docs/uml/graph.png
#	src/main/java/ev3dev/actuators/LCD.java
#	src/main/java/ev3dev/hardware/EV3DevDistros.java
#	src/main/java/ev3dev/hardware/EV3DevPlatforms.java
#	src/main/java/ev3dev/sensors/Battery.java
#	src/main/java/ev3dev/utils/Brickman.java
#	src/test/java/ev3dev/utils/SysfsTest.java
jabrena added a commit that referenced this issue Oct 30, 2018
@jabrena
Merge pull request #540 from ev3dev-lang-java/feature/#498_review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2f011a6 
Code fixes for Feature/#498
jabrena added a commit that referenced this issue Nov 3, 2018
@jabrena
Merge remote-tracking branch 'origin/feature/#498' into feature/#498
Loading status checks…
cbc920c 
# Conflicts:
#	src/main/java/ev3dev/sensors/GenericMode.java
#	src/main/java/ev3dev/sensors/ev3/EV3ColorSensor.java
#	src/main/java/ev3dev/sensors/ev3/EV3GyroSensor.java
#	src/main/java/ev3dev/sensors/ev3/EV3IRSensor.java
#	src/main/java/ev3dev/sensors/ev3/EV3TouchSensor.java
#	src/main/java/ev3dev/sensors/ev3/EV3UltrasonicSensor.java
#	src/main/java/ev3dev/sensors/mindsensors/AbsoluteIMU.java
jabrena added a commit that referenced this issue Nov 3, 2018
@jabrena
Merge pull request #539 from ev3dev-lang-java/feature/#498
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
96947b5 
Feature/#498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jabrena jabrena

Labels
Java UML design development refactoring resolved
Projects
None yet
Milestone
v0.9.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@jabrena
You can’t perform that action at this time.