★ wanayoo — archive 1999 https://github.com/fehiepsi/rethinking-numpyro/pull/6Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - in chapter 4, correct the bspline model section (changed in final copy of the book) #6

Merged
merged 1 commit into from Aug 23, 2020

Conversation

@ksachdeva
Copy link
Contributor

@ksachdeva ksachdeva commented Aug 23, 2020

In the final edition, for the BSpline model, the doy column is used (instead of temp). The loc and scale in the model are also very different from December 2019 draft

In Code 4.76, you will notice a comment regarding explicit state initialization of a to 100. Without this model fails to converge. I had tried to increase the sample size but it was in vain. With a 's initial state set around 100, I am able to correctly reproduce the figures from the book.

…al copy of the book)
@fehiepsi
Copy link
Owner

@fehiepsi fehiepsi commented Aug 23, 2020

Thanks for the update, @ksachdeva! The diff is so large due to svg format. I'll update the notebooks so that I will use default backend in github and use svg backend when rendered to the website. After that, your future contributions will be much easier to review. :)

I had tried to increase the sample size but it was in vain.

I think the reason is the parameters have not been optimized by Adam optimizer yet. You would need to observe the loss and change learning rate, the number of iterations accordingly. :) After jax 0.1.74, there is BFGS optimizer which does not require tuning learning rate but we haven't included it in NumPyro yet. I think SR author also uses BFGS optimizer for his book.

@fehiepsi fehiepsi merged commit e3a98df into fehiepsi:master Aug 23, 2020
2 checks passed
2 checks passed
chapters_d01234 (3.6)
Details
chapters_d56789 (3.6)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.