★ wanayoo — archive 1999 https://github.com/fehiepsi/rethinking-numpyro/pull/7Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - in chapter 8, correct the ordering, add missing cells & adjust implementation of some models #7

Merged
merged 1 commit into from Aug 25, 2020

Conversation

@ksachdeva
Copy link
Contributor

@ksachdeva ksachdeva commented Aug 24, 2020

Hi @fehiepsi

Unfortunately, this PR has many changes. you had few code cells missing (8.6, 8.9 & 8.11) and that led to incorrect ordering. Also, the usage of d_A1 in early models was incorrect; since you were not printing the precis you did not notice it. I have fixed it as appropriate. I have verified that all the numbers are the same as that of the book.

It may be a good idea to add https://www.reviewnb.com/ addon to your account. For OSS repo it is free. This should help in the review.

Regards
Kapil

…lementation of some models
@fehiepsi
Copy link
Owner

@fehiepsi fehiepsi commented Aug 25, 2020

Thanks so much, @ksachdeva! Sorry, I promised to avoid using svg backend but didn't make it yet. Could you wait for me a bit, then merge master, and rerun your notebook? I believe the diff will be much better.

@fehiepsi
Copy link
Owner

@fehiepsi fehiepsi commented Aug 25, 2020

Oops, you did mention about reviewnb. It is awesome. I'll do it instead. :D

Thanks!!

@fehiepsi
Copy link
Owner

@fehiepsi fehiepsi commented Aug 25, 2020

Not sure if you can access: here is the diff. It is nice that we can comment there. But I still prefer disabling svg to view the diff and comment directly in github. :D

Copy link
Owner

@fehiepsi fehiepsi left a comment

Awesome!!! There is only one issue at Code 8.26, where we shoudn't provide blooms_std arg (to get predictive prior). Thanks a lot, @ksachdeva!

@fehiepsi fehiepsi merged commit b605cff into fehiepsi:master Aug 25, 2020
2 checks passed
2 checks passed
chapters_d01234 (3.6)
Details
chapters_d56789 (3.6)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.