fix - in chapter 8, correct the ordering, add missing cells & adjust implementation of some models #7
Conversation
…lementation of some models
|
Thanks so much, @ksachdeva! Sorry, I promised to avoid using |
|
Oops, you did mention about Thanks!! |
|
Not sure if you can access: here is the diff. It is nice that we can comment there. But I still prefer disabling |
|
Awesome!!! There is only one issue at Code 8.26, where we shoudn't provide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi @fehiepsi
Unfortunately, this PR has many changes. you had few code cells missing (8.6, 8.9 & 8.11) and that led to incorrect ordering. Also, the usage of d_A1 in early models was incorrect; since you were not printing the precis you did not notice it. I have fixed it as appropriate. I have verified that all the numbers are the same as that of the book.
It may be a good idea to add https://www.reviewnb.com/ addon to your account. For OSS repo it is free. This should help in the review.
Regards
Kapil