Ignore module manifest unless forced #7281
Merged
Conversation
loganfsmyth
added a commit
that referenced
this pull request
Nov 16, 2018
|
I don't think this has any effect as-is. If a file is in the index, Git detects changes to it even when ignored. Maybe we'd be best off adding an option to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
We've been getting loads of PRs with errant changes to this file, so IMO we should ignore it and then force-update it when we do a release.