★ wanayoo — archive 1999 https://github.com/firefox-devtools/debugger/pull/7489Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't transform object spread #7489

Merged
merged 1 commit into from Dec 12, 2018

Conversation

@nchevobbe
Copy link
Member

@nchevobbe nchevobbe commented Dec 12, 2018

Fixes #7223

@nchevobbe
Copy link
Member Author

@nchevobbe nchevobbe commented Dec 12, 2018

Using this to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1496044 (TRY)

I checked the debugger in launchpad and it works fine.
I thought we had that at some point, not sure when the syntax-object-spread was replaced.

@jasonLaster
Copy link
Contributor

@jasonLaster jasonLaster commented Dec 12, 2018

we do the same thing in copy-modules, but yeah. looks like this didn't help reps and other modules...

@jasonLaster jasonLaster merged commit 30b0065 into firefox-devtools:master Dec 12, 2018
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kenjiO
Copy link
Contributor

@kenjiO kenjiO commented Dec 12, 2018

@jasonLaster Should this be removed from package.json now?

diff --git a/package.json b/package.json
index 4da85106..cf7b5631 100644
--- a/package.json
+++ b/package.json
@@ -50,7 +50,6 @@
   "dependencies": {
     "@babel/core": "^7.0.0-beta.55",
     "@babel/parser": "^7.0.0-beta.55",
-    "@babel/plugin-proposal-object-rest-spread": "^7.0.0-beta.55",
     "@babel/template": "^7.0.0-beta.55",
     "@babel/types": "^7.0.0-beta.55",
     "babel-plugin-transform-imports": "^1.5.0",
@jasonLaster
Copy link
Contributor

@jasonLaster jasonLaster commented Dec 12, 2018

@kenjiO yep!

jasonLaster pushed a commit that referenced this pull request Dec 14, 2018
jasonLaster pushed a commit that referenced this pull request Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants