★ wanayoo — archive 1999 https://github.com/firefox-devtools/debugger/pull/8018Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name of repository #8018

Merged
merged 1 commit into from Feb 22, 2019
Merged

Conversation

@kevinmorehouse
Copy link
Contributor

@kevinmorehouse kevinmorehouse commented Feb 22, 2019

Updated doc to reflect new name of repository (debugger) and removed references to old repository name (debugger.html), as decided in PR #8009 .

Fixes N/A

Summary of Changes

  • Replaced any instances of debugger.html with debugger (or removed them altogether)
  • Fixed capitalization of "debugger" on line 60.
Updated doc to reflect new name of repository (_debugger_) and removed old references to old repository name (_debugger.html_), as decided in PR #8009 

Also made one capitalization change on line 60.
@kevinmorehouse
Copy link
Contributor Author

@kevinmorehouse kevinmorehouse commented Feb 22, 2019

Am I correct in assuming that the directory name on line 32 should be changed from debugger.html to debugger, along with the rest of the changes?

@kevinmorehouse
Copy link
Contributor Author

@kevinmorehouse kevinmorehouse commented Feb 22, 2019

The community call link (on lines 83 and 114) still points to https://appear.in/debugger.html.

Is the team going to still meet at that url, or are you going to use a new one now?

@jasonLaster jasonLaster merged commit 8a97c43 into firefox-devtools:master Feb 22, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ci/circleci Your tests passed on CircleCI!
Details
@jasonLaster
Copy link
Contributor

@jasonLaster jasonLaster commented Feb 22, 2019

I think we should change debugger.html, but that also means updating appear.in too!

@jasonLaster
Copy link
Contributor

@jasonLaster jasonLaster commented Feb 22, 2019

Okay, nevermind i think that is taken, lets use https://appear.in/firefox-debugger

@kevinmorehouse kevinmorehouse deleted the kevinmorehouse:patch-2 branch Feb 23, 2019
jasonLaster added a commit that referenced this pull request Feb 25, 2019
Updates the link to the community call to reflect the new appear.in room (https://appear.in/firefox-debugger), as discussed with @jasonLaster in PR #8018. 

#8018 (comment)
jasonLaster pushed a commit that referenced this pull request Mar 7, 2019
Updated doc to reflect new name of repository (_debugger_) and removed old references to old repository name (_debugger.html_), as decided in PR #8009 

Also made one capitalization change on line 60.
jasonLaster pushed a commit that referenced this pull request Mar 7, 2019
Updates the link to the community call to reflect the new appear.in room (https://appear.in/firefox-debugger), as discussed with @jasonLaster in PR #8018. 

#8018 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants