★ wanayoo — archive 1999 https://github.com/gitalk/gitalk/pull/364Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if this.token is null, there is no need to fetch user profile through github api #364

Merged
merged 1 commit into from May 13, 2020

Conversation

@geektutu
Copy link
Contributor

@geektutu geektutu commented Mar 5, 2020

if this.token is null, there is no need to fetch user profile through github api

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint).
  6. Commit your changes (git commit) Commit Message Format Reference.
@booxood booxood merged commit f2f5c5e into gitalk:master May 13, 2020
2 checks passed
2 checks passed
build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.