★ wanayoo — archive 1999 https://github.com/github/gitignore/pull/2802Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .nox directory for the nox testing tool #2802

Merged
merged 1 commit into from Sep 9, 2018
Merged

Conversation

@sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Sep 9, 2018

Reasons for making this change:

This is a new Python testing tool, similar to tox and is being used in a lot of Google Cloud projects.

Links to documentation supporting these rule changes:

Couldn't find specific documentation about the .nox/ directory but the tool uses this directory to house it's virtualenvs.

@shiftkey
Copy link
Member

@shiftkey shiftkey commented Sep 9, 2018

I couldn't find docs, but I saw a couple of projects also using this rule and I found this code:

    parser.add_argument(
        "--envdir", default=".nox", help="Directory where nox will store virtualenvs."
    )

Feel free to add a comment here if you see any other details about this, but for now I'm good to merge this in!

@shiftkey shiftkey merged commit 35441e9 into github:master Sep 9, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sethmlarson
Copy link
Contributor Author

@sethmlarson sethmlarson commented Sep 9, 2018

Thanks! cc: @theacodes

@sethmlarson sethmlarson deleted the sethmlarson:patch-1 branch Sep 9, 2018
@theacodes
Copy link

@theacodes theacodes commented Sep 10, 2018

Oh, this is awesome. Thank you @SethMichaelLarson and @shiftkey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants