[SECURITY] Use HTTPS to resolve dependencies in Maven Build #1184
Conversation
This fixes a security vulnerability in this project where the `pom.xml` files were configuring Maven to resolve dependencies over HTTP instead of HTTPS. Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
|
Thanks @JLLeitschuh |
BurhanH
added a commit
to BurhanH/java-design-patterns
that referenced
this pull request
May 18, 2020
* Type object pattern iluwatar#555 (iluwatar#848) * typeobject pattern * fixing errors * fix error cellpool * Update README.md * Update README.md * Change Travis CI build env. to Trusty (iluwatar#911) * 508 : sonar qube critical issue fixes (iluwatar#852) * 508 : sonar qube critical issue fixes * 508 : Sunar Qube Fixes Define a constant instead of duplicating this literal "user_accounts" 4 times. Define a constant instead of duplicating this literal "userID" 5 times Define a constant instead of duplicating this literal "additionalInfo" 4 times. Define a constant instead of duplicating this literal "userName" 4 times. * 508 : Sunar Qube Fixes Define a constant instead of duplicating this literal "user_accounts" 4 times. * 508 : Sonar Qube Fixes Define a constant instead of duplicating this literal "eEvans" 4 times Define a constant instead of duplicating this literal "jBloch" 6 times Define a constant instead of duplicating this literal "mFowler" 3 times * 508 : Sonar Qube FIxes Define a constant instead of duplicating this literal "username" 3 times. * 508: sonar qube issue fixes Define a constant instead of duplicating this literal "customerDao.getAllCustomers(): " 4 times. * 508 : sonar qube issue fixes Define a constant instead of duplicating this literal "App.main(), student : " 4 times. * 508 : sonar Qube issue fixes Define a constant instead of duplicating this literal "{} hits {}. {} is damaged!" 3 times. Define a constant instead of duplicating this literal "{} hits {}." 4 times. * 508 : Define a constant instead of duplicating this literal "{} hits {}." 4 times. * 508 : checkstyle fixes * 508: checkstyle fixes * 508: checkstyle fixes * 508: checkstyle fixes * 508: checkstyle fixes * 508: checkstyle fixes * 508: cqrs checkstyle fixes * 508 : Sonar qube critical Issue Fix (iluwatar#854) * 508 : Sonar qube critical Issue Fix Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed. * 508: Sonar Qube Issue fxes Define a constant instead of duplicating this literal " does not exist." 3 times. * 508: sonar qube issue fixes Define a constant instead of duplicating this literal "Some external api for only realtime execution could be called here." 3 times. * Add licenses * Commander pattern iluwatar#505 (iluwatar#857) * Commander pattern * Fix checkstyle errors * Update Commander.java * Update README.md * Update PaymentService.java * Update Commander.java * Update README.md * Best practice when compare enum (iluwatar#869) * Fix the dependency conflict issue (iluwatar#872) * Modify Observer pattern UML (iluwatar#877) * Typo coresponding -> corresponding (iluwatar#879) * fixed failing tests (iluwatar#860) (iluwatar#880) * Added one more Credit/Article about the benefits of Repository pattern (iluwatar#882) * Remove the transitive dependency(junit-jupiter-api) (iluwatar#916) * fixed bug iluwatar#883 (iluwatar#885) * fix code example containing syntax error (iluwatar#890) * Update SonarCloud badge * Create .sonarcloud.properties * Added priority queue design pattern (iluwatar#888) * added priority queue design pattern * Minor Refactored, fixed review comments * Bytecode pattern iluwatar#553 (iluwatar#896) * Added bytecode pattern * Diagram changed and added licence information * Added bytecode module to main pom. * Fixed missing dependency error * MInor bug fix Issue iluwatar#895 -> Code comment change (iluwatar#895) (iluwatar#901) * fix must override a superclass method (iluwatar#919) * fix must override a superclass method * fix must override a superclass method * clean code (iluwatar#910) * Fix issue iluwatar#761: ThreadSafeDoubleCheckLocking.java: Instantiating by Reflection call will be successful if you do that firstly (iluwatar#920) * Fix broken links iluwatar#915 (iluwatar#921) * Java Design Patterns v1.21.0 * Set version for next development iteration * Add license headers * Updating README.md file to update doc as suggested in issue#925 (iluwatar#926) * Data Locality pattern iluwatar#559 (iluwatar#889) * Data Locality pattern iluwatar#559 * Fixed review comments * updated pom * Fixed failed build * Removing the dead link to resove automagic issue as mentioned in issue#915 (iluwatar#927) * fixed bug iluwatar#929: close async service before the main thread finishes (iluwatar#931) * Fix for BallThreadTest#testResume (iluwatar#935) * Fix for flaky test * Remove other file changes * Remove other file changes * Remove other file changes not related to bug * added new information (iluwatar#937) * iluwatar#834 Fix dependency management issue for POM files (iluwatar#940) * Upgrade of maven plugins (iluwatar#951) * Upgrade maven plugins * Upgrade maven plugins Some general code cleanup was necessary due to upgrade of PMD and checkstyle. Also needed to add Junit 4 as a dependency due to Mockito.timout issue found here: mockito/mockito#152 * Get rid of build warnings WARNING about problems found when building the effective model (iluwatar#953) * Add JXR plugin to get rid of WARNING Unable to locate Source XRef to link to (iluwatar#952) * Fix for Issue iluwatar#549 : Update Exception Handling Code in Aggregator Microservice (iluwatar#958) * Fix for Issue#iluwatar#549 Catch ClientProtocolException and Update Error Logs * Fix indentation, checkstyle errors * Fix for issue iluwatar#954 : Add external Dependencies to run with Java11 (iluwatar#957) * Fix for issue iluwatar#954 Add javax.annotation and java.xml.bind as external maven dependencies Verified with jdk-11 * Move dependency versions to main pom.xml's dependencyManagement section * Fix link in Acyclic Visitor * update buggy dependencies (iluwatar#968) * Fix: Github reports security vulnerabilities iluwatar#933 (iluwatar#960) * Fix: Github reports security vulnerabilities iluwatar#933 Upgrade camel and spring-data * -Fix github security vulnerabilities in spring-data and camel * -Code changes for review comments * iluwatar#496 Pipeline pattern (iluwatar#967) * iluwatar#496 Add pipeline module to parent pom✨ * iluwatar#496: Add main application class and test for pipeline * iluwatar#496: Checkstyle format and add log messages on pipeline stages🎨 * iluwatar#496: Fill readme sections of pipeline✨ * iluwatar#496: Javadocs and checkstyle formatting🎨 * iluwatar#496: Follow PMD checks and add more explanation as block comment on App.java * iluwatar#496: Apply requested PR changes by iluwatar🎨 * Close iluwatar#969 (iluwatar#972) * Leader Election Pattern (iluwatar#923) * Fix issue iluwatar#761: ThreadSafeDoubleCheckLocking.java: Instantiating by Reflection call will be successful if you do that firstly * Create leader election module * Create Interface of Instance and MessageManager * Create implementations with token ring algorithm * Change package structure. Create basic message system. * Implement heartbeat and heartbeat invoking message system * Implement election message handler * Add leader message handler * Add main entry point * Add comments * Update README.md * Fix checkstyle issue * Add Unit Tests * Add Unit Tests * Add bully leader selection * Change System.out to log print. Add MIT license in each file. * Add More java doc comments * Add unit test * Add unit tests * Configure Travis to build on JDK8 and JDK11 * Fix Travis xvfb * Maven profiles to support jdk 11 builds. iluwatar#948 (iluwatar#975) * Maven profiles to support jdk 11 builds. iluwatar#948 Added maven profiles activated by jdk 11, wich will not break java 8 support. Bumped lombok and datanucleus enhancer as the old versions dont work with 11. * Fixed PMD issue when building naked-objects * Fixed the eip modules with xml dependencies. Previous dependency relaxing commit causes xml libs to go missing from some modules that actually needed them * Bump java language to 11 (iluwatar#980) * Moved java XML and annotations dependencies to project level instead of as profiles * Set compiler language level to 11 * Removed jdk8 from travis build * Kept java level 8 in naked-objects/dom for datanucleus enhancer, for now. * [mvn] - Remove maven-pmd-plugin from the project (iluwatar#977) (iluwatar#979) * Update license headers * iluwatar#996 Fix SonarCloud analysis failure (iluwatar#997) * iluwatar#996 Update Travis config * iluwatar#996 Remove old secret * iluwatar#996 add coverage profile * iluwatar#996 move jacoco out of profile * iluwatar#970 single logging framework should be enforced (iluwatar#982) * iluwatar#496 Add pipeline module to parent pom✨ * iluwatar#496: Add main application class and test for pipeline * iluwatar#496: Checkstyle format and add log messages on pipeline stages🎨 * iluwatar#496: Fill readme sections of pipeline✨ * iluwatar#496: Javadocs and checkstyle formatting🎨 * iluwatar#496: Follow PMD checks and add more explanation as block comment on App.java * iluwatar#496: Apply requested PR changes by iluwatar🎨 * iluwatar#970: Replace log4j usage on commander pattern to Slf4j API🎨 * iluwatar#970: Replace log4j usage on dao pattern to Slf4j API🎨 * iluwatar#970: Replace log4j usage on data mapper pattern to Slf4j API🎨 * iluwatar#970: Remove log4j dependency on data transfer object pom🔥 * iluwatar#970: Replace log4j usage on module pattern to Slf4j API🎨 * iluwatar#970: Replace log4j usage on serverless pattern to Slf4j API🎨 This also removes the aws log4j dependency * iluwatar#970: Remove unnecessary gitignore line for log4j.xml🔥 * iluwatar#970: Remove remaining remnants of log4j🔥 * iluwatar#970: Replace System.out logging with appropriate logging methods🎨 * iluwatar#970: Replace System.out method references to Logger::info🎨 * iluwatar#996 set sonar host url * iluwatar#996 disable sonar analysis for pull requests (iluwatar#999) * Fix for issue iluwatar#413: Circuit Breaker Pattern (iluwatar#986) * Fix Issue iluwatar#413: Circuit-Breaker Pattern * Fix Image Links * Remove Javadoc plugin to ensure correct build * Implementing code review feedback * Sync README with actual code * 988: Replaced all of the Apache HttpClients with Java's java.net.http (iluwatar#1003) * 988: Took out the apache http component from root pom.xml * 988: Updated the aggregator sub projects to use java.net.http instead of apache * 988: Updated the api-gateway-service sub projects to use java.net.http instead of apache * Applied the code style formatter * 993: Fixed the pipeines project layout so that it will load in Eclipse (iluwatar#1004) The source directory was not working in the 2019.09 version of Eclipse. The problem was in the layout of the project: after the src/main/java and src/test/java, the directory was naed com.iluwatar.pipeline. It should've been com/iluwatar/pipeline. This follows the hierarchy of all of the other patterns. Once these files were moved, the Pipeline project compiled without errors. * Intermittent test failure in Spatial Partition pattern iluwatar#1001 (iluwatar#1006) * Intermittent test failure in Spatial Partition pattern iluwatar#1001 * Intermittent test failure in Spatial Partition pattern iluwatar#1001 * iluwatar#1001 fix intermittent test failure (iluwatar#1008) * iluwatar#554: Subclass Sandbox pattern (iluwatar#998) * Fix issue iluwatar#761: ThreadSafeDoubleCheckLocking.java: Instantiating by Reflection call will be successful if you do that firstly * Create leader election module * Create Interface of Instance and MessageManager * Create implementations with token ring algorithm * Change package structure. Create basic message system. * Implement heartbeat and heartbeat invoking message system * Implement election message handler * Add leader message handler * Add main entry point * Add comments * Update README.md * Fix checkstyle issue * Add Unit Tests * Add Unit Tests * Add bully leader selection * Change System.out to log print. Add MIT license in each file. * Add More java doc comments * Add unit test * Add unit tests * Add subclass-sandbox * Add Unit Test * Add Unit Test * Fix Typo * Move dependency into parent pom.xml * Change local valuable reference to be var * Fixes iluwatar#1007 by updating JUnit to 5.5.2 (iluwatar#1015) The missing class PreconditionViolationException is contained in junit-platform-commons which comes in transitively by this JUnit version. junit-jupiter-api had to be added because spring-boot-dependencies imports an older version of this dependency. * 1011: Fixed all of the SonarCloud blocking errors (iluwatar#1017) * 1011: Added the method to the RequestMapping annotation * 1011: Changed all of the a href blank targets to include rel="noopener noreferrer" * Update README.md * init repo for role object * add to init * Switched to embedded Google checkstyle rules (iluwatar#1018) * Switched to embedded Google checkstyle rules Moved the configuration out of the execution to make it used in all executions. Fixes iluwatar#1016 * iluwatar#1016: Moved checkstyle configuration back into execution This refactoring may be better done in a new issue as it may have too many implication. * Replaced consoleOutput and failsOnError by failOnViolation consoleOutput outputs everything while failsOnError just fails the build but doesn't log the error. failOnViolation fails on a violation and logs it (logViolationsToConsole defaults to true). * Remove obsolete file * 1010: Fixed all of the blocking and critical Sonarcloud errors (iluwatar#1020) * 1011: Added SuppressWarnings for SonarCloud errors All of these files are causing SonarCloud to report the following error: Loops should not be infinite Since these instances all require an infinite loop that will never end, these warnings should be disabled so that SonarCloud no longer reports them as error. The rule is: squid:S2189 * 1011: Made all of the randoms static and final According to SonarCloud rule: "Random" objects should be reused, randoms should not be recreated. This commit has taken all of the Randoms and made them constant variables in the files that are using them. * add to init * Update FAQ metadata * 1010: Fixed the two remaining SonarCloud errors (iluwatar#1023) The two remaining files were still creating a Random everytime the method was called. These were missed in the previous commit because the previous commit had fixed only one of the methods; in other words, there were multiple methods that were creating the Random object on each call. * Issue#550: double buffer pattern (iluwatar#1024) * Basic implementation * implement double buffer * add unit test * add unit test * Add Readme * Change local value declaration to var * Remove unused fields * iluwatar#984 local variable inference changes (iluwatar#1025) * iluwatar#984 Fix for abstract-document, abstract-factory, acyclic-visitor, adapter, aggregator-microservices * iluwatar#984 Fix for abstract-document, abstract-factory, acyclic-visitor, adapter, aggregator-microservices * add first impl * improve grammar of README (iluwatar#945) * improve grammar of README * Update README.md * Use local variable type inference (iluwatar#995) * "visitor" pattern: Use local variable type inference Update "visitor" pattern with local variable type inference. * "value-object" pattern: Use local variable type inference Update "value-object" pattern with local variable type inference. * "unit-of-work" pattern: Use local variable type inference Update "value-object" pattern with local variable type inference. * "typeobjectpattern" pattern: Use local variable type inference Update "value-object" pattern with local variable type inference. * iluwatar#1021: Fix checkstyle warnings by changing the license header template (iluwatar#1027) * Add custom license header style in order to comply with Google's Checkstyle format * Update license headers to comply with Google's Checkstyle format * local variable type inference changes (iluwatar#1028) * local variable type inference changes replacing type with var * the type changed back to String since it is initializing to null and later having different value, it is throwing error in Travis-CI. Made changes. * add pattern * add license * Update keywords * iluwatar#1009 - remove child poms overhead information (iluwatar#1030) * iluwatar#1009 - remove child versions * iluwatar#1009 - add custom jaxb version for cqrs * iluwatar#1016 - decrease number of checkstyle errors in adapter pattern (iluwatar#1033) * Create FUNDING.yml * service-layer local type inference changes (iluwatar#1034) local variable type inference for service-layer design patterns * local variable type inference changes (iluwatar#1035) local variable type inference changes for design pattern service locator * local variable type inference changes (iluwatar#1036) local variable type inference changes for design pattern singleton * local variable infere changes (iluwatar#1038) local variable infere changes for STATE design pattern * local variable type inference changes (iluwatar#1039) local variable type inference changes for step builder design pattern * local variable type inference changes (iluwatar#1040) local variable type inference changes for strategy design pattern * local variable type inference changes (iluwatar#1041) local variable type inference changes for template method design pattern * local variable type inference changes (iluwatar#1043) local variable type inference changes for throttling design pattern * local variable type inference changes (iluwatar#1042) * local variable type inference changes local variable type inference changes for thread pool design pattern * local variable type inference changes local variable type inference changes for ThreadPool design pattern * iluwatar#984 for unitofwork, tolerantreader, twin (iluwatar#1044) * iluwatar#984 for unitofwork, tolerantreader, twin * iluwatar#984 for unitofwork, tolerantreader, twin * iluwatar#987 for visitor, value-object, unitofwork, typeobjectpattern, tolerantreader, twin, tranpoline * add changes * Update Github token * Fix error when building from a submodule directory (iluwatar#1045) Add directory-maven-plugin to resolve the location of the license-plugin-header-style.xml from a submodule directory * The pattern Role object (iluwatar#1031) * init repo for role object * add to init * add to init * add first impl * add pattern * add license * add changes * Update license headers * Fix Role Object front matter * Add java 11 (iluwatar#1048) * Add java 11 (iluwatar#1049) * Use java 11 (iluwatar#1050) * Add java 11 support for iluwatar#987 (o-t) (iluwatar#1051) * Use java 11 * Use .of - Replace Arrays.asList with List.of - Replace HashSet<>(List.of()) with Set.of * Formatting * Update web site logic * Update script * Update script * Update script * iluwatar#1021 - decrease number of checkstyle errors in callback pattern (iluwatar#1053) * Update license header * Issue 893 (iluwatar#1014) * Using static object to reduce memory foot prints * Updating README along with name of static fields * Updating code as per review comments * Updating code as per review comments * Updating doc as per new code * Move faq.md to java-design-patterns-web repository * Remove presentations * decrease number of checkstyle errors in singleton, strategy and visitor patterns iluwatar#1021 (iluwatar#1054) * fix checkstlye errors - visitor pattern * fix checkstlye errors - strategy pattern * fix checkstlye errors - singleton pattern * Fix remaining Checkstyle errors for Singleton * Fix for Issue iluwatar#549 : Add Fallbacks in Aggregator Service (iluwatar#971) * Fix for Issue#iluwatar#549 Catch ClientProtocolException and Update Error Logs * Fix indentation, checkstyle errors * Fix for Issue iluwatar#549 Add fallbacks in Aggregator service when other microservices fail * Make ProductInventoryClientImpl return null instead of zero in case of failure * iluwatar#1021 style changes for Specification * add saga init dsc * add init saga dsc * add changes to dsc * iluwatar#590 Add explanation for Specification pattern * add * add orchestrator * add ch * separate pkgs * add info * iluwatar#1021 Checkstyle fixes for Composite pattern * iluwatar#1021 Checkstyle changes for Factory Method * iluwatar#1021 Checkstyle fixes for Layers * iluwatar#590 arrange Layers into packages and add explanation * Sharding Pattern (iluwatar#1056) * Create sharding module * Add Unit Tests * Fix readme hyperlink * Fix check-style issue * add choreogr * rem space * Resolves checkstyle errors for ambassador, async-method-invocation, balking, bridge, builder (iluwatar#1058) * Decreases checkstyle errors for ambassador pattern * Reduces checkstyle errors in async-method-invocation * Reduces checkstyle errors in balking * Reduces checkstyle errors in bridge * Reduces checkstyle errors in builder * Resolves checkstyle errors for business-delegate, bytecode, caching (iluwatar#1059) * Reduces checkstyle errors in business-delegate * Reduces checkstyle errors in bytecode * Reduces checkstyle errors in caching * Resolves checkstyle errors for callback, chain, circuit-breaker (iluwatar#1060) * Reduces checkstyle errors in callback * Reduces checkstyle errors in chain * Reduces checkstyle errors in circuit-breaker * Resolves checkstyle errors for collection-pipeline, command, commander (iluwatar#1061) * Reduces checkstyle errors in collection-pipeline * Reduces checkstyle errors in command * Reduces checkstyle errors in commander * change according to cgeckstyle * Resolves checkstyle errors for converter, cqrs (iluwatar#1063) * Reduces checkstyle errors in converter * Reduces checkstyle errors in cqrs * Resolves checkstyle errors for guarded-suspension, half-sync-half-async, hexagonal (iluwatar#1064) * Reduces checkstyle errors in guarded-suspension * Reduces checkstyle errors in half-sync-half-async * Reduces checkstyle errors in hexagonal * Resolves checkstyle errors for intercepting-filter, interpreter, iterator (iluwatar#1065) * Reduces checkstyle errors in intercepting-filter * Reduces checkstyle errors in interpreter * Reduces checkstyle errors in iterator * Resolves checkstyle errors for api-gateway, lazy-loading, leader-election (iluwatar#1066) * Reduces checkstyle errors in lazy-loading * Reduces checkstyle errors in leader-election * Reduces checkstyle errors in api-gateway * Resolves checkstyle errors for dao data-bus data-locality data-mapper data-transfer-object decorator (iluwatar#1067) * Reduces checkstyle errors in dao * Reduces checkstyle errors in data-bus * Reduces checkstyle errors in data-locality * Reduces checkstyle errors in data-mapper * Reduces checkstyle errors in data-transfer-object * Reduces checkstyle errors in decorator * Resolves checkstyle errors for delegation dependency-injection dirty-flag double-buffer double-checked-locking double-dispatch (iluwatar#1068) * Reduces checkstyle errors in delegation * Reduces checkstyle errors in dependency-injection * Reduces checkstyle errors in dirty-flag * Reduces checkstyle errors in double-buffer * Reduces checkstyle errors in double-checked-locking * Reduces checkstyle errors in double-dispatch * Resolves checkstyle errors for eip-* (iluwatar#1069) * Reduces checkstyle errors in eip-aggregator * Reduces checkstyle errors in eip-message-channel * Reduces checkstyle errors in eip-publish-subscribe * Reduces checkstyle errors in eip-splitter * Reduces checkstyle errors in eip-wire-tap * Resolves checkstyle errors for event-* (iluwatar#1070) * Reduces checkstyle errors in event-aggregator * Reduces checkstyle errors in event-asynchronous * Reduces checkstyle errors in event-driven-architecture * Reduces checkstyle errors in event-queue * Reduces checkstyle errors in event-sourcing * Resolves checkstyle errors for execute-around extension-objects (iluwatar#1071) * Reduces checkstyle errors in execute-around * Reduces checkstyle errors in extension-objects * Resolves checkstyle errors for patterns starting with letter r (iluwatar#1072) * Reduces checkstyle errors in reactor * Reduces checkstyle errors in reader-writer-lock * Reduces checkstyle errors in repository * Reduces checkstyle errors in resource-acquisition-is-initialization * Reduces checkstyle errors in retry * Resolves checkstyle errors for template-method thread-pool throttling tls tolerant-reader (iluwatar#1073) * Reduces checkstyle errors in template-method * Reduces checkstyle errors in thread-pool * Reduces checkstyle errors in throttling * Reduces checkstyle errors in tls * Reduces checkstyle errors in tolerant-reader * Resolves checkstyle errors for trampoline twin typeobjectpattern unit-of-work value-object (iluwatar#1074) * Reduces checkstyle errors in trampoline * Reduces checkstyle errors in twin * Reduces checkstyle errors in typeobjectpattern * Reduces checkstyle errors in unit-of-work * Reduces checkstyle errors in value-object * Java 11 migration: ambassador async-method-invocation balking bridge builder (iluwatar#1076) * Moves ambassador pattern to java 11 * Moves async-method-invocation pattern to java 11 * Moves balking pattern to java 11 * Moves bridge pattern to java 11 * Moves builder pattern to java 11 * iluwatar#984 update Ambassador readme * iluwatar#984 update Bridge readme * iluwatar#984 update Builder readme * Resolves checkstyle errors for facade factory-kit spatial-partition state step-builder (iluwatar#1077) * Reduces checkstyle errors in facade * Reduces checkstyle errors in factory-kit * Reduces checkstyle errors in spatial-partition * Reduces checkstyle errors in state * Reduces checkstyle errors in step-builder * Resolves checkstyle errors for feature-toggle fluentinterface flux flyweight front-controller (iluwatar#1078) * Reduces checkstyle errors in feature-toggle * Reduces checkstyle errors in fluentinterface * Reduces checkstyle errors in flux * Reduces checkstyle errors in flyweight * Reduces checkstyle errors in front-controller * Resolves checkstyle issues for semaphore servant serverless service-layer service-locator (iluwatar#1079) * Reduces checkstyle errors in semaphore * Reduces checkstyle errors in servant * Reduces checkstyle errors in serverless * Reduces checkstyle errors in service-layer * Reduces checkstyle errors in service-locator * Resolves checkstyle errors for abstract-document abstract-factory acyclic-visitor adapter aggregator-microservices (iluwatar#1080) * Reduces checkstyle errors in abstract-document * Reduces checkstyle errors in abstract-factory * Reduces checkstyle errors in acyclic-visitor * Reduces checkstyle errors in adapter * Reduces checkstyle errors in aggregator-microservices * Resolves checkstyle errors for naked-objects null-object object-mother object-pool observer queue-load-leveling (iluwatar#1082) * Reduces checkstyle errors in naked-objects * Reduces checkstyle errors in null-object * Reduces checkstyle errors in object-mother * Reduces checkstyle errors in object-pool * Reduces checkstyle errors in observer * Reduces checkstyle errors in queue-load-leveling * Java 11 migration: patterns (remaining b-c) (iluwatar#1081) * Moves business-delegate pattern to java 11 * Moves bytecode pattern to java 11 * Moves caching pattern to java 11 * Moves callback pattern to java 11 * Moves chain pattern to java 11 * Moves circuit-breaker pattern to java 11 * Moves collection-pipeline pattern to java 11 * Moves command pattern to java 11 * Moves commander pattern to java 11 * Moves composite pattern to java 11 * Corrects test cases * iluwatar#984 iluwatar#987 update readmes * Java 11 migration: patterns starting with a (iluwatar#1084) * Moves abstract-factory pattern to java 11 * Moves abstract-document pattern to java 11 * Moves acyclic-visitor pattern to java 11 * Moves adapter pattern to java 11 * Moves aggregator-microservices pattern to java 11 * Moves api-gateway pattern to java 11 * Add another real world example for Builder * add changes according to google style * Java 11 migration: patterns (t-v) (iluwatar#1085) * Moves visitor pattern to java 11 * Moves value-object pattern to java 11 * Moves unit-of-work pattern to java 11 * Moves typeobjectpattern pattern to java 11 * Moves twin pattern to java 11 * Moves trampoline pattern to java 11 * Moves tolerant-reader pattern to java 11 * Moves tls pattern to java 11 * Moves throttling pattern to java 11 * Moves thread-pool pattern to java 11 * Moves template-method pattern to java 11 * Saga pattern (iluwatar#1062) * init repo for role object * add to init * add to init * add first impl * add pattern * add license * add changes * add saga init dsc * add init saga dsc * add changes to dsc * add * add orchestrator * add ch * separate pkgs * add info * add choreogr * rem space * change according to cgeckstyle * add changes according to google style * Adding parameterized specification (Issue#1055) (iluwatar#1088) * Resolution proposition to Issue#1055 (UML diagram left to do) * Deciding not to modify the UML diagram for now * Game Loop Pattern (iluwatar#1083) * Add game loop module * Add game loop module * Fix merge issue * Implement game loop module * Implement game loop module * Implement time based game loop * implement VariableStepGameLoop * Implement FixedStepGameLoop * Add UT * Add Unit tests * Fix checkstyle issues * Add README.md * Fix code review issues * Fix code review issues * update README.md * Resolves checkstyle errors for remaining m (iluwatar#1090) * Reduces checkstyle errors in marker * Reduces checkstyle errors in master-worker-pattern * Reduces checkstyle errors in mediator * Reduces checkstyle errors in memento * Reduces checkstyle errors in model-view-controller * Reduces checkstyle errors in model-view-presenter * Reduces checkstyle errors in module * Reduces checkstyle errors in monad * Reduces checkstyle errors in monostate * Reduces checkstyle errors in multiton * Reduces checkstyle errors in mute-idiom * Reduces checkstyle errors in mutex * Resolves checkstyle errors for remaining p (iluwatar#1091) * Reduces checkstyle errors in page-object * Reduces checkstyle errors in partial-response * Reduces checkstyle errors in pipeline * Reduces checkstyle errors in poison-pill * Reduces checkstyle errors in priority-queue * Reduces checkstyle errors in private-class-data * Reduces checkstyle errors in property * Reduces checkstyle errors in prototype * Reduces checkstyle errors in proxy * iluwatar#1021 enforce Checkstyle rules in the build * iluwatar#590 Add explanation for Converter pattern * Add game-loop to parent pom.xml * Fix several frontmatter issues * Adding composite specification (Issue#1093) (iluwatar#1094) * Resolution proposition to Issue#1055 (UML diagram left to do) * Deciding not to modify the UML diagram for now * Resolution proposition to Issue#1093 * Code reformatting * Java Design Patterns 1.22.0 * Set version for next development iteration * Add some formatting to Specification pattern readme * Changes aggregation to composition (as described in issue iluwatar#1095) (iluwatar#1096) * Update App.java (iluwatar#1098) * Changes the implementation of the prototype pattern (iluwatar#1103) * Changes the implementation of the prototype pattern * Fixes the checkstyle warnings * Fixes additional checkstyle warnings * Package patterns into executable jars setup (iluwatar#1092) * Adding support for maven assembly plugin to generate executable jar with all dependencies in built * Merge branch 'master' into issue-989 # Conflicts: # abstract-document/pom.xml # pom.xml * Adding maven assemly plugin for projects with name A * Update in format as per checkstyle, i.e. Spcae in place of tab with size of 2 * Changes the description of the template method pattern (as discussed in Issue1099) (iluwatar#1101) * Declares the template methods as final * Extends the description of the template method pattern * Removes the final declarations (this was done in another branch) * Changes the description of the prototype pattern (iluwatar#1102) * Pattern combinator (iluwatar#1105) * init * add pattern * Update Method pattern (iluwatar#1106) * Add update method pattern * Add unit tests * Add README.md * Resolve conflict * iluwatar#1113 Add uml-reverse-mapper plugin * iluwatar#1113 Link uml-reverse-mapper created class diagrams to readme, where needed * Java 11 migrate remaining e (iluwatar#1112) * Moves eip-aggregator to Java 11 * Moves eip-message-channel to Java 11 * Moves eip-publish-subscribe to Java 11 * Moves eip-splitter to Java 11 * Moves eip-wire-tap to Java 11 * Moves event-aggregator to Java 11 * Moves event-asynchronous to Java 11 * Moves event-driven-architecture to Java 11 * Moves event-queue to Java 11 * Moves event-sourcing to Java 11 * Moves execute-around to Java 11 * Moves extension-objects to Java 11 * Fix Acyclic Visitor readme layout * iluwatar/java-design-patterns-web#8 Update pattern categories and tags * iluwatar/java-design-patterns-web#8 Fix typo in tag * Java 11 migrate c-d (remaining) (iluwatar#1111) * Moves converter pattern to Java 11 * Moves cqrs pattern to Java 11 * Moves dao pattern to Java 11 * Moves data-bus pattern to Java 11 * Moves data-locality pattern to Java 11 * Moves data-mapper pattern to Java 11 * Moves data-transfer-object pattern to Java 11 * Moves decorator pattern to Java 11 * Moves delegation pattern to Java 11 * Moves dependency-injection to Java 11 * Moves dirty-flag to Java 11 * Moves double-buffer to Java 11 * Moves double-checked-locking to Java 11 * Moves double-dispatch to Java 11 * Corrects with changes thats breaking test cases * Issue 989 batch-2 (iluwatar#1108) * Adding support for maven assembly plugin to generate executable jar with all dependencies in built * Merge branch 'master' into issue-989 # Conflicts: # abstract-document/pom.xml # pom.xml * Adding maven assemly plugin for projects with name A * Update in format as per checkstyle, i.e. Spcae in place of tab with size of 2 * batch set - 2 having all project with B and C * issue-989 d-e-f * fixing eip pom and adding g-h-i-l-m-n Skipping naked object as it seems it doesn't have main method, will consider this at end * Adding for O and P projects Skipping Object-Mother as we don't have main method for same. * Java 11 migrate remaining (g,h,i) (iluwatar#1116) * Moves game-loop to Java 11 * Moves guarded-suspension to Java 11 * Moves half-sync-half-async to Java 11 * Moves hexagonal to Java 11 * Moves intercepting-filter to Java 11 * Moves interpreter to Java 11 * Moves iterator to Java 11 * Java 11 migrate 7 remaining f (iluwatar#1115) * Moves facade to Java 11 * Moves factory-kit to Java 11 * Moves factory-method to Java 11 * Moves feature-toggle to Java 11 * Moves fluentinterface to Java 11 * Moves flux to Java 11 * Moves flyweight to Java 11 * Moves front-controller to Java 11 * Uses stream properly * Resolves issues with ci * Issue 989 final-batch (iluwatar#1119) * Adding support for maven assembly plugin to generate executable jar with all dependencies in built * Merge branch 'master' into issue-989 # Conflicts: # abstract-document/pom.xml # pom.xml * Adding maven assemly plugin for projects with name A * Update in format as per checkstyle, i.e. Spcae in place of tab with size of 2 * batch set - 2 having all project with B and C * issue-989 d-e-f * fixing eip pom and adding g-h-i-l-m-n Skipping naked object as it seems it doesn't have main method, will consider this at end * Adding for O and P projects Skipping Object-Mother as we don't have main method for same. * Final batch * Java 11 migrate all remaining s (iluwatar#1120) * Moves saga to Java 11 * Moves semaphore to Java 11 * Moves servant to Java 11 * Moves serverless to Java 11 * Moves service-layer to Java 11 * Moves service-locator to Java 11 * Moves sharding to Java 11 * Moves singleton to Java 11 * Moves spatial-partition to Java 11 * Moves specification to Java 11 * Moves state to Java 11 * Moves step-builder to Java 11 * Moves strategy to Java 11 * Moves subclass-sandbox to Java 11 * Fixes checkstyle issues * Java 11 migrate remaining q-r (iluwatar#1121) * Moves queue-load-leveling to Java 11 * Moves reactor to Java 11 * Moves reader-writer-lock to Java 11 * Moves repository to Java 11 * Moves resource-acquisition-is-initialization to Java 11 * Moves retry to Java 11 * Moves role-object to Java 11 * LICENSE: Happy new year! (iluwatar#1123) * Update LICENSE.md * Update LICENSE.md * Bump maven-surefire-plugin from 3.0.0-M3 to 3.0.0-M4 (iluwatar#1126) Bumps [maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.0.0-M3 to 3.0.0-M4. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.0.0-M3...surefire-3.0.0-M4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump mongo-java-driver from 3.3.0 to 3.12.0 (iluwatar#1127) Bumps [mongo-java-driver](https://github.com/mongodb/mongo-java-driver) from 3.3.0 to 3.12.0. - [Release notes](https://github.com/mongodb/mongo-java-driver/releases) - [Commits](mongodb/mongo-java-driver@r3.3.0...r3.12.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump maven-war-plugin from 2.4 to 3.2.3 (iluwatar#1129) Bumps [maven-war-plugin](https://github.com/apache/maven-war-plugin) from 2.4 to 3.2.3. - [Release notes](https://github.com/apache/maven-war-plugin/releases) - [Commits](apache/maven-war-plugin@maven-war-plugin-2.4...maven-war-plugin-3.2.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Revert "Bump maven-war-plugin from 2.4 to 3.2.3 (iluwatar#1129)" This reverts commit b99d375. * Bump guava-testlib from 19.0 to 23.0 (iluwatar#1130) Bumps [guava-testlib](https://github.com/google/guava) from 19.0 to 23.0. - [Release notes](https://github.com/google/guava/releases) - [Commits](google/guava@v19.0...v23.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix markdown (iluwatar#1131) * Abstract document add module info file (iluwatar#1118) * Added module-info.java file in abstract document pattern * Renamed module name and added the required module. * [Security] Bump jackson.version from 2.8.5 to 2.10.2 (iluwatar#1133) Bumps `jackson.version` from 2.8.5 to 2.10.2. Updates `jackson-core` from 2.8.5 to 2.10.2 - [Release notes](https://github.com/FasterXML/jackson-core/releases) - [Commits](FasterXML/jackson-core@jackson-core-2.8.5...jackson-core-2.10.2) Updates `jackson-databind` from 2.8.5 to 2.10.2 - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) Updates `jackson-annotations` from 2.8.5 to 2.10.2 - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump mongodb-driver from 3.0.4 to 3.12.0 (iluwatar#1135) Bumps [mongodb-driver](https://github.com/mongodb/mongo-java-driver) from 3.0.4 to 3.12.0. - [Release notes](https://github.com/mongodb/mongo-java-driver/releases) - [Commits](mongodb/mongo-java-driver@r3.0.4...r3.12.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Revert "Bump maven-surefire-plugin from 3.0.0-M3 to 3.0.0-M4 (iluwatar#1126)" This reverts commit f00523f. * Java 11 migrate remaining p (iluwatar#1122) * Moves partial-response to Java 11 * Moves pipeline to Java 11 * Moves poison-pill to Java 11 * Moves priority-queue to Java 11 * Moves private-class-data to Java 11 * Moves producer-consumer to Java 11 * Moves promise to Java 11 * Moves property to Java 11 * Moves prototype to Java 11 * Moves proxy to Java 11 * Corrects checkstyle errors * Fixes build for pipeline pattern * Bump gson from 2.8.1 to 2.8.6 (iluwatar#1147) Bumps [gson](https://github.com/google/gson) from 2.8.1 to 2.8.6. - [Release notes](https://github.com/google/gson/releases) - [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md) - [Commits](google/gson@gson-parent-2.8.1...gson-parent-2.8.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump slf4j-api from 1.7.28 to 1.7.30 (iluwatar#1153) Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.28 to 1.7.30. - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](qos-ch/slf4j@v_1.7.28...v_1.7.30) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump mongo-java-driver from 3.12.0 to 3.12.1 (iluwatar#1169) Bumps [mongo-java-driver](https://github.com/mongodb/mongo-java-driver) from 3.12.0 to 3.12.1. - [Release notes](https://github.com/mongodb/mongo-java-driver/releases) - [Commits](mongodb/mongo-java-driver@r3.12.0...r3.12.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump javassist from 3.25.0-GA to 3.26.0-GA (iluwatar#1170) Bumps [javassist](https://github.com/jboss-javassist/javassist) from 3.25.0-GA to 3.26.0-GA. - [Release notes](https://github.com/jboss-javassist/javassist/releases) - [Commits](https://github.com/jboss-javassist/javassist/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump mongodb-driver from 3.12.0 to 3.12.1 (iluwatar#1173) Bumps [mongodb-driver](https://github.com/mongodb/mongo-java-driver) from 3.12.0 to 3.12.1. - [Release notes](https://github.com/mongodb/mongo-java-driver/releases) - [Commits](mongodb/mongo-java-driver@r3.12.0...r3.12.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Modularization for 2 more modules (iluwatar#1177) 1. Abstract Factory 2. Acyclic Visitor * Modularisation for 2 patterns: (iluwatar#1178) 1. Business-delegate 2, Callback * Modularisation for design patterns: (iluwatar#1179) 1. Chain 2. Collection-Pipeline * Fix imperative-style. (iluwatar#1180) Signed-off-by: yichen88 <tang.yichenyves@gmail.com> * Organised below design patterns into modules: (iluwatar#1181) 1. Command 2. Composite * Organised below design patterns into modules: (iluwatar#1182) 1. Converter 2. Dao * Organised below design patterns into modules: (iluwatar#1183) 1. Data Mapper 2. Data Transfer Object * Organised the below patterns into modules: (iluwatar#1185) 1. Decorator 2. Delegation * Import of design patterns into modules: (iluwatar#1186) 1. DIrty flag 2. Double checked locking * Organisation of patterns into modules: (iluwatar#1187) 1. Double DIspatch 2. EIP Message Channel * Organisation of design patterns into modules: (iluwatar#1188) 1. EIP Publish Channel 2. Event Aggregator * Use HTTPS instead of HTTP to resolve dependencies (iluwatar#1184) This fixes a security vulnerability in this project where the `pom.xml` files were configuring Maven to resolve dependencies over HTTP instead of HTTPS. Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com> * Java 11 support for iluwatar#984 iluwatar#987 (l) (iluwatar#1190) * Java 11 support: lazy-loading pattern * Java 11 support: layers pattern * Java 11 support: leader-election/lazy-loading patterns * Remove lombok dependency * Bump mockito-all from 1.9.5 to 1.10.19 (iluwatar#1202) Bumps [mockito-all](https://github.com/mockito/mockito) from 1.9.5 to 1.10.19. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v1.9.5...v1.10.19) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump slf4j-test from 1.0.0 to 1.2.0 (iluwatar#1204) Bumps slf4j-test from 1.0.0 to 1.2.0. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Organisation of design patterns into modules (iluwatar#1208) 1. Event Asynchoronous 2. Execute Around * Arranged design patterns into modules: (iluwatar#1209) 1. Facade 2. Factory Kit * Arranged following design patterns into modules: (iluwatar#1210) 1. Factory Method 2. Feature Toggle * Fix issue iluwatar#179: Leader Followers Pattern (iluwatar#1189) * add leader followers pattern * use var and streams instead in App::execute * use logger instead of printing to system output stream * Changing Aggregator Microservices pattern link (iluwatar#1214) Page doesn't exist anymore, so changed to use web archive * add java 11 support (o) (iluwatar#1222) * Fix issue iluwatar#1218: Arrange, Act, Assert pattern (iluwatar#1221) * add AAA pattern * reformat comment * use Testing in readme tags in stead of Unit Test Co-authored-by: AnaghaSasikumar <42939261+AnaghaSasikumar@users.noreply.github.com> Co-authored-by: ptrax <zachtrax@gmail.com> Co-authored-by: kanwarpreet25 <39183641+kanwarpreet25@users.noreply.github.com> Co-authored-by: Ilkka Seppälä <ilkka.seppala@gofore.com> Co-authored-by: hoangnam2261 <31692990+hoangnam2261@users.noreply.github.com> Co-authored-by: HelloCoCooo <46306510+HelloCoCooo@users.noreply.github.com> Co-authored-by: DRad <progdrad@gmail.com> Co-authored-by: pierDipi <33736985+pierDipi@users.noreply.github.com> Co-authored-by: S Sethi <shilpa.sethi@outlook.com> Co-authored-by: Thiago Medeiros <si-thiago@hotmail.com> Co-authored-by: Ranjeet <ranjeet.floyd@gmail.com> Co-authored-by: Aravind M <makaravind11195@gmail.com> Co-authored-by: Ilkka Seppälä <iluwatar@users.noreply.github.com> Co-authored-by: Pawel Zawitowski <zawito@gmail.com> Co-authored-by: saksham93 <37399540+saksham93@users.noreply.github.com> Co-authored-by: dongshengchen <anancds@163.com> Co-authored-by: Ibrahim ali abdelghany <eng.ibrahim222@gmail.com> Co-authored-by: Adrian Yao <azureyjt@gmail.com> Co-authored-by: snehalatapandit <snehlatapandit2592@gmail.com> Co-authored-by: Hemant Bothra <hemant.bothra15@gmail.com> Co-authored-by: Zhang WH <npczwh@163.com> Co-authored-by: Anirudh <rockstreetani@gmail.com> Co-authored-by: Denise <dignat@yahoo.com> Co-authored-by: Per Wramdemark <per@wramdemark.se> Co-authored-by: Arpit Jain <jarpit96@gmail.com> Co-authored-by: Kevin O'Neal <oneal.kevin@gmail.com> Co-authored-by: Gaurav Deshpande <gaurav9822@gmail.com> Co-authored-by: Joshua Jimenez <jimenez.johnjoshua.jjj@gmail.com> Co-authored-by: erikgajdos1997 <56270468+erikgajdos1997@users.noreply.github.com> Co-authored-by: lbroman <leonard.broman@gmail.com> Co-authored-by: shumyk <dima.shumyk@gmail.com> Co-authored-by: Aditya Pal <adityapal.nghss@gmail.com> Co-authored-by: Christopher O'Connell <coconnell84@gmail.com> Co-authored-by: Sharad Paul <paul.sharadchandra@gmail.com> Co-authored-by: Michele Giacobazzi <smirne@gmail.com> Co-authored-by: Kai Winter <kaiwinter@gmx.de> Co-authored-by: Besok <zhguchev@gmail.com> Co-authored-by: Anurag870 <f2005870@gmail.com> Co-authored-by: Jonathan Lao-kan <oneofdays@gmail.com> Co-authored-by: Zack Beach <z.beach@icloud.com> Co-authored-by: Alexander Ivanov <vanogrid@gmail.com> Co-authored-by: GVSharma <gvsharma4@gmail.com> Co-authored-by: adamski.pro <k@adamski.pro> Co-authored-by: Boris <zhguchev@hotmail.com> Co-authored-by: Leon Mak <leonmak@users.noreply.github.com> Co-authored-by: adamski.pro <akrystian@gmail.com> Co-authored-by: Leonóra Dér <6597652+leonorader@users.noreply.github.com> Co-authored-by: Anurag Agarwal <anurag.agarwal561994@gmail.com> Co-authored-by: Martin Vandenbussche <vandenbusschemartin@gmail.com> Co-authored-by: Martin Vandenbussche <martin.vandenbussche@student.uclouvain.be> Co-authored-by: Dominik Gruntz <dominik.gruntz@fhnw.ch> Co-authored-by: Angel_Kitty <angelkitty6698@gmail.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Lulzx <wiserishabh@gmail.com> Co-authored-by: yichen88 <30594441+yichen88@users.noreply.github.com> Co-authored-by: Jonathan Leitschuh <jonathan.leitschuh@gmail.com> Co-authored-by: Jacob Hell <jakehell95@gmail.com>
Code-13
added a commit
to Code-13/java-design-patterns
that referenced
this pull request
Jun 22, 2020
This fixes a security vulnerability in this project where the `pom.xml` files were configuring Maven to resolve dependencies over HTTP instead of HTTPS. Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is a security fix for a vulnerability in your Apache Maven
pom.xmlfile(s).The build files indicate that this project is resolving dependencies over HTTP instead of HTTPS.
This leaves your build vulnerable to allowing a Man in the Middle (MITM) attackers to execute arbitrary code on your or your computer or CI/CD system.
This vulnerability has a CVSS v3.0 Base Score of 8.1/10.
POC code has existed since 2014 to maliciously compromise a JAR file in-flight.
MITM attacks against HTTP are increasingly common, for example Comcast is known to have done it to their own users.
This contribution is a part of a submission to the GitHub Security Lab Bug Bounty program.
Detecting this and Future Vulnerabilities
This vulnerability was automatically detected by LGTM.com using this CodeQL Query.
As of September 2019 LGTM.com and Semmle are officially a part of GitHub.
You can automatically detect future vulnerabilities like this by enabling the free (for open-source) LGTM App.
I'm not an employee of GitHub nor of Semmle, I'm simply a user of LGTM.com and an open-source security researcher.
Source
Yes, this contribution was automatically generated, however, the code to generate this PR was lovingly hand crafted to bring this security fix to your repository.
The source code that generated and submitted this PR can be found here:
JLLeitschuh/bulk-security-pr-generator
Opting-Out
If you'd like to opt-out of future automated security vulnerability fixes like this, please consider adding a file called
.github/GH-ROBOTS.txtto your repository with the line:This bot will respect the ROBOTS.txt format for future contributions.
Alternatively, if this project is no longer actively maintained, consider archiving the repository.
CLA Requirements
This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.
It is unlikely that I'll be able to directly sign CLAs. However, all contributed commits are already automatically signed-off.
If signing your organization's CLA is a strict-requirement for merging this contribution, please feel free to close this PR.
Tracking
All PR's generated as part of this fix are tracked here:
JLLeitschuh/bulk-security-pr-generator#2