★ wanayoo — archive 1999 https://github.com/iluwatar/java-design-patterns/pull/1234Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin pattern #1234

Open
wants to merge 35 commits into
base: master
from
Open

plugin pattern #1234

wants to merge 35 commits into from

Conversation

@jasciiz
Copy link

@jasciiz jasciiz commented May 8, 2020

plugin pattern for issue #351

  • add plugin pattern
jasciiz added 30 commits May 6, 2020
Fix issue #1218: Arrange, Act, Assert pattern (#1221)
jasciiz added 5 commits May 31, 2020
title: Federated Identity
folder: federated-identity
permalink: /patterns/federated-identity/
categories: Decoupling

This comment has been minimized.

@iluwatar

iluwatar Jun 25, 2020
Owner

Suggested change
categories: Decoupling
categories: Integration
permalink: /patterns/federated-identity/
categories: Decoupling
tags:
- authentication

This comment has been minimized.

@iluwatar

iluwatar Jun 25, 2020
Owner

Suggested change
- authentication
- Decoupling
- authentication
---
## Also known as
claims-based access control

This comment has been minimized.

@iluwatar

iluwatar Jun 25, 2020
Owner

Suggested change
claims-based access control
Claims-based access control
claims-based access control

## Intent
The Federated Identity pattern simplify development, minimize the requirement for user administration, and improve the user experience of the application.

This comment has been minimized.

@iluwatar

iluwatar Jun 25, 2020
Owner

I think we should also mention that it's about authentication, and especially integrating an external authentication mechanism

<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
<version>1.8.0-beta4</version>

This comment has been minimized.

@iluwatar

iluwatar Jun 25, 2020
Owner

Please use the versions declared in the parent pom.xml. Check this elsewhere too.

try{
this.data = sdf.parse(data);
}catch (ParseException e){
e.printStackTrace();

This comment has been minimized.

@iluwatar

iluwatar Jun 25, 2020
Owner

Please use logger for output. Check this elsewhere too.

* <p>
*/
public Consumer(){
this.name = "iluwater";

This comment has been minimized.

@iluwatar

iluwatar Jun 25, 2020
Owner

Suggested change
this.name = "iluwater";
this.name = "iluwatar";
* when no get response from IdP.
*/
public void register() {
StringBuilder stringBuilder = new StringBuilder();

This comment has been minimized.

private OpenApiPlugin getConfiguredOpenApiPlugin() {
Info info = new Info().version("1.0").description("RESTful Corpus Platform API");
OpenApiOptions options = new OpenApiOptions(info)
.activateAnnotationScanningFor("com.iluwater.dederatedIdentity.IdP")

This comment has been minimized.

@iluwatar

iluwatar Jun 25, 2020
Owner

Suggested change
.activateAnnotationScanningFor("com.iluwater.dederatedIdentity.IdP")
.activateAnnotationScanningFor("com.iluwatar.dederatedIdentity.IdP")
}

@Test
public void test1(){

This comment has been minimized.

@iluwatar

iluwatar Jun 25, 2020
Owner

Please use meaningful names for the tests so it's easy to see at a glance what it does

@iluwatar iluwatar self-assigned this Jun 25, 2020
@iluwatar
Copy link
Owner

@iluwatar iluwatar commented Jun 25, 2020

Please find the review comments above. When you're ready for another review please comment on this issue. Thanks!

@iluwatar
Copy link
Owner

@iluwatar iluwatar commented Jun 25, 2020

The correct issue this PR is implementing is #443

@iluwatar
Copy link
Owner

@iluwatar iluwatar commented Aug 3, 2020

@jasciiz The pull request has remained inactive and is about to be closed. Please comment if you're still working on it.

@ohbus ohbus added the status:stale label Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.