★ wanayoo — archive 1999 https://github.com/iluwatar/java-design-patterns/pull/1237Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1086 Implement microkernel architecture pattern #1237

Open
wants to merge 1 commit into
base: master
from

Conversation

@RudolfBun
Copy link

@RudolfBun RudolfBun commented May 12, 2020

Pull request
Microkernel architecture pattern implementation
The related issue: #1086

@@ -0,0 +1,78 @@
---
layout: pattern
title: microkernel architecture

This comment has been minimized.

@iluwatar

iluwatar May 31, 2020
Owner

Suggested change
title: microkernel architecture
title: Microkernel Architecture
## Consequences
The Microkernel pattern offers some important **benefits**:
- Portability
- Flexibility and Extensibility

This comment has been minimized.

@iluwatar

iluwatar May 31, 2020
Owner

Suggested change
- Flexibility and Extensibility
- Flexibility and extensibility
- Portability
- Flexibility and Extensibility
- Separation of policy and mechanism
- Scakability

This comment has been minimized.

@iluwatar

iluwatar May 31, 2020
Owner

Suggested change
- Scakability
- Scalability
package com.iluwatar.microkernel;

import com.iluwatar.microkernel.clients.Client;

This comment has been minimized.

@iluwatar

iluwatar May 31, 2020
Owner

Please add here a brief explanation how this example implements the pattern. See the other patterns in the repository for examples.

*/
public static void main(String[] args) {

Client client = new Client();

This comment has been minimized.

@iluwatar

iluwatar May 31, 2020
Owner

We can use Java 11 var here

This comment has been minimized.

@iluwatar

iluwatar May 31, 2020
Owner

Check this throughout the code and utilize the new language features

*/
public class Adapter {

private BudgetMicrokernel microkernel;

This comment has been minimized.

@iluwatar

iluwatar May 31, 2020
Owner

Use final keyword

This comment has been minimized.

@iluwatar

iluwatar May 31, 2020
Owner

Check this elsewhere too. Make the members final if they are not modified after the initialization.

This comment has been minimized.

@mookkiah

mookkiah Oct 12, 2020
Contributor

@iluwatar Is it a good idea to request authors as part of PR template to sonarqube lint tools to verify locally for avoid critical issues? This gives opportunity for the developer to look at smaller issues as well.

This comment has been minimized.

@iluwatar

iluwatar Nov 8, 2020
Owner

In principle yes, but I'm afraid it makes creating pull requests more complicated. It would be great if the CI build could check for Sonarqube issues in the incoming changed code. Not sure if Sonarcloud can be configured to do that..


private void executeService() {
double income = calculateForecast(this.incomes);
System.out.println("The next income forecast: " + income);

This comment has been minimized.

@iluwatar

iluwatar May 31, 2020
Owner

Please use a logger component for output

* @param accounts as all registered accounts
*/
public BudgetMicrokernel(Map<Integer, Account> accounts) {
this.accounts = Objects.requireNonNullElseGet(accounts, HashMap::new);

This comment has been minimized.

@iluwatar

iluwatar May 31, 2020
Owner

this keyword is unnecessary

}

@Test
void receiveRequest() {

This comment has been minimized.

@iluwatar

iluwatar May 31, 2020
Owner

Please use meaningful names for the tests, so it becomes self-explanatory what they do

@iluwatar
Copy link
Owner

@iluwatar iluwatar commented May 31, 2020

There is a conflict preventing merge.

@iluwatar
Copy link
Owner

@iluwatar iluwatar commented May 31, 2020

@RudolfBun let me know when the PR is ready for another review.

@iluwatar iluwatar self-assigned this Jul 6, 2020
@iluwatar
Copy link
Owner

@iluwatar iluwatar commented Aug 3, 2020

@RudolfBun The pull request has remained inactive and is about to be closed. Please comment if you're still working on it.

@freison
freison approved these changes Sep 5, 2020
@freison
freison approved these changes Sep 5, 2020
@ohbus ohbus added the status:stale label Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.