★ wanayoo — archive 1999 https://github.com/iluwatar/java-design-patterns/pull/1560Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📍Use lombok, reformat, and optimize the code #1560

Open
wants to merge 4 commits into
base: master
from

Conversation

@va1m
Copy link

@va1m va1m commented Oct 12, 2020

Use lombok

  • Replace boiled code by lombok annotations
  • #1503

Pull request description

  • Use @Slf4j instead of LOGGER var definition and initialisation
  • Use @Getter and @Setter instead of vanila java implementations
  • Use @ToString instead of custom implementations
  • Use @EqualsAndHashcode instead of manually created equals() and hashCode()
  • Autoformat project java classes
  • Remove public for test methods using JUnit5
@sumitaccess007
Copy link

@sumitaccess007 sumitaccess007 commented Oct 17, 2020

Hi @iluwatar
Can I start working on this to refactor the code and use Lombok Library, If yes, please assign to me.

@va1m
Copy link
Author

@va1m va1m commented Oct 17, 2020 •

Hi @iluwatar
Can I start working on this to refactor the code and use Lombok Library, If yes, please assign to me.

Hi @sumitaccess007, this pull request already uses lombok library.

va1m and others added 3 commits Oct 17, 2020
Sync masters
…ure/va1m/simplify

# Conflicts:
#	trampoline/src/test/java/com/iluwatar/trampoline/TrampolineAppTest.java
@va1m
Copy link
Author

@va1m va1m commented Oct 24, 2020

@iluwatar, can you please review the PR?

@va1m va1m changed the title Use lombok, reformat, and optimize the code 📍Use lombok, reformat, and optimize the code Oct 24, 2020
Copy link
Collaborator

@ohbus ohbus left a comment

This is a very long Pull Request and will take time to get reviewed.

Copy link
Collaborator

@ohbus ohbus left a comment

I have also seen that you have made changes in Junit code as well.
But have not mentioned it in the PR description.

It would be great if you could provide a solid documentation for each changes in the PR.

@iluwatar
Copy link
Owner

@iluwatar iluwatar commented Dec 4, 2020

There are conflicts that need to be resolved @va1m

@iluwatar iluwatar self-assigned this Dec 6, 2020
Copy link
Owner

@iluwatar iluwatar left a comment

The changes look good to me and we can merge it once the conflict have been resolved.

  • In the future please keep the pull request scope smaller, for example one PR per pattern would be much easier to review and merge quickly. It takes an hour or two to even read through the changes when there are 692 files changed.
  • Try to avoid incorporating unrelated changes in the same pull request. Like here there were hundreds of changes in test files, reformatting and small bug fixes.
  • I added a page to our wiki collecting the allowed Lombok annotations: https://github.com/iluwatar/java-design-patterns/wiki/18.-Lombok Please comments if there's something missing that we are using/want to use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.