📍Use lombok, reformat, and optimize the code #1560
Open
Conversation
|
Hi @iluwatar |
Hi @sumitaccess007, this pull request already uses lombok library. |
Sync masters
…ure/va1m/simplify # Conflicts: # trampoline/src/test/java/com/iluwatar/trampoline/TrampolineAppTest.java
|
@iluwatar, can you please review the PR? |
|
This is a very long Pull Request and will take time to get reviewed. |
|
I have also seen that you have made changes in Junit code as well. It would be great if you could provide a solid documentation for each changes in the PR. |
|
There are conflicts that need to be resolved @va1m |
|
The changes look good to me and we can merge it once the conflict have been resolved.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Use lombok
Pull request description
@Slf4jinstead of LOGGER var definition and initialisation@Getterand@Setterinstead of vanila java implementations@ToStringinstead of custom implementations@EqualsAndHashcodeinstead of manually createdequals()andhashCode()publicfor test methods using JUnit5