★ wanayoo — archive 1999 https://github.com/jetstack/testing/pull/224Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarmak disable bootstap py #224

Merged
merged 3 commits into from Apr 11, 2019
Merged

Tarmak disable bootstap py #224

merged 3 commits into from Apr 11, 2019

Conversation

@simonswine
Copy link
Contributor

@simonswine simonswine commented Apr 11, 2019

No description provided.

@jetstack-bot
Copy link
Collaborator

@jetstack-bot jetstack-bot commented Apr 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonswine simonswine force-pushed the tarmak-disable-bootstap-py branch from 50d5f63 to 3c2ee92 Apr 11, 2019
@@ -129,133 +79,7 @@
trigger: "(?m)^/test( all| acceptance),?(\\s+|$)"
rerun_command: "/test acceptance"

This comment has been minimized.

@munnerz

munnerz Apr 11, 2019
Contributor

I think the trigger and rerun command here should be removed, in order to force users of this template to set them explicitly?

This comment has been minimized.

@simonswine

simonswine Apr 11, 2019
Author Contributor

Makes sense

simonswine added 3 commits Apr 11, 2019
Signed-off-by: Christian Simon <simon@swine.de>
* Fixes #211

Signed-off-by: Christian Simon <simon@swine.de>
Signed-off-by: Christian Simon <simon@swine.de>
@simonswine simonswine force-pushed the tarmak-disable-bootstap-py branch from cb85d6c to 470511c Apr 11, 2019
@munnerz
Copy link
Contributor

@munnerz munnerz commented Apr 11, 2019

/lgtm

@jetstack-bot jetstack-bot added the lgtm label Apr 11, 2019
@jetstack-bot jetstack-bot merged commit c50553b into master Apr 11, 2019
4 of 5 checks passed
4 of 5 checks passed
tide Not mergeable. Needs lgtm label.
Details
dco All commits have Signed-off-by
Details
pull-testing-build Job succeeded.
Details
pull-testing-config Job succeeded.
Details
pull-testing-verify Job succeeded.
Details
@jetstack-bot
Copy link
Collaborator

@jetstack-bot jetstack-bot commented Apr 11, 2019

@simonswine: Updated the job-config configmap in namespace default using the following files:

  • key tarmak-presubmits.yaml using file config/jobs/tarmak/tarmak-presubmits.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.