Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Adds presubmit jobs for cert-manager-csi #305
Conversation
| @@ -39,6 +39,8 @@ branch-protection: | |||
| - pull-cert-manager-deps | |||
| - pull-cert-manager-chart | |||
| - pull-cert-manager-e2e-v1-15 | |||
| - pull-cert-manager-csi | |||
munnerz
Nov 5, 2019
Contributor
pull-cert-manager-csi-verify for consistency?
pull-cert-manager-csi-verify for consistency?
| @@ -39,6 +39,8 @@ branch-protection: | |||
| - pull-cert-manager-deps | |||
| - pull-cert-manager-chart | |||
| - pull-cert-manager-e2e-v1-15 | |||
| - pull-cert-manager-csi | |||
| - pull-cert-manager-csi-e2e-v16-v11 | |||
munnerz
Nov 5, 2019
Contributor
v16-v11? I guess this is meant to be v{kube_minor}-v{cm_minor}, but it isn't really intuitive IMO.
I think pull-cert-manager-csi-e2e-v1-16 is fine - the presubmit here needn't really care much about the CM version. We can create periodic jobs for testing the matrix of CM versions and include the CM version number in the name there. Storing two versions creates confusion and long names 😓
v16-v11? I guess this is meant to be v{kube_minor}-v{cm_minor}, but it isn't really intuitive IMO.
I think pull-cert-manager-csi-e2e-v1-16 is fine - the presubmit here needn't really care much about the CM version. We can create periodic jobs for testing the matrix of CM versions and include the CM version number in the name there. Storing two versions creates confusion and long names
JoshVanL
Nov 5, 2019
Author
Member
👍
| agent: kubernetes | ||
| decorate: true | ||
| branches: | ||
| - master |
munnerz
Nov 5, 2019
Contributor
Should technically by ^master$ as this is a regex (we don't do this elsewhere, I know 😬 )
Should technically by ^master$ as this is a regex (we don't do this elsewhere, I know
| containers: | ||
| - image: golang:1.13.4 | ||
| args: | ||
| - hack/docker-start-wrapper.sh |
munnerz
Nov 5, 2019
Contributor
What is docker-start-wrapper? 🤔
If you need dind, we already have a base image you can use that will automatically setup dind when setting DOCKER_IN_DOCKER_ENABLED
What is docker-start-wrapper?
If you need dind, we already have a base image you can use that will automatically setup dind when setting DOCKER_IN_DOCKER_ENABLED
JoshVanL
Nov 5, 2019
Author
Member
I remember having problems with this in the past. Does this require bazel?
I remember having problems with this in the past. Does this require bazel?
JoshVanL
Nov 5, 2019
Author
Member
To set up that is
To set up that is
munnerz
Nov 7, 2019
Contributor
Nope it doesn't
Nope it doesn't
|
/hold |
|
/unassign @munnerz |
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoshVanL, munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
| containers: | ||
| - image: eu.gcr.io/jetstack-build-infra-images/golang-dind:20191205-e920769-1.13.4 | ||
| args: | ||
| - make |
munnerz
Dec 11, 2019
Contributor
If you are using dind, you'll need to prepend runner as an arg here in order to start the initialisation script (i.e. to start the docker daemon). Same on the verify job.
If you are using dind, you'll need to prepend runner as an arg here in order to start the initialisation script (i.e. to start the docker daemon). Same on the verify job.
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
|
Back to you @munnerz |
|
/hold cancel |
|
/lgtm |
|
@JoshVanL: Updated the following 4 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: JoshVanL vleeuwenjoshua@gmail.com
Adds presubmit jobs and other config for the CSI driver.
Will add periodic jobs once things are looking good.
/assign @munnerz