★ wanayoo — archive 1999 https://github.com/jetstack/testing/pull/305Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds presubmit jobs for cert-manager-csi #305

Merged
merged 4 commits into from Dec 11, 2019

Conversation

@JoshVanL
Copy link
Member

@JoshVanL JoshVanL commented Nov 5, 2019

Signed-off-by: JoshVanL vleeuwenjoshua@gmail.com

Adds presubmit jobs and other config for the CSI driver.

Will add periodic jobs once things are looking good.

/assign @munnerz

@@ -39,6 +39,8 @@ branch-protection:
- pull-cert-manager-deps
- pull-cert-manager-chart
- pull-cert-manager-e2e-v1-15
- pull-cert-manager-csi

This comment has been minimized.

@munnerz

munnerz Nov 5, 2019
Contributor

pull-cert-manager-csi-verify for consistency?

@@ -39,6 +39,8 @@ branch-protection:
- pull-cert-manager-deps
- pull-cert-manager-chart
- pull-cert-manager-e2e-v1-15
- pull-cert-manager-csi
- pull-cert-manager-csi-e2e-v16-v11

This comment has been minimized.

@munnerz

munnerz Nov 5, 2019
Contributor

v16-v11? I guess this is meant to be v{kube_minor}-v{cm_minor}, but it isn't really intuitive IMO.

I think pull-cert-manager-csi-e2e-v1-16 is fine - the presubmit here needn't really care much about the CM version. We can create periodic jobs for testing the matrix of CM versions and include the CM version number in the name there. Storing two versions creates confusion and long names 😓

This comment has been minimized.

@JoshVanL

JoshVanL Nov 5, 2019
Author Member

👍

agent: kubernetes
decorate: true
branches:
- master

This comment has been minimized.

@munnerz

munnerz Nov 5, 2019
Contributor

Should technically by ^master$ as this is a regex (we don't do this elsewhere, I know 😬)

containers:
- image: golang:1.13.4
args:
- hack/docker-start-wrapper.sh

This comment has been minimized.

@munnerz

munnerz Nov 5, 2019
Contributor

What is docker-start-wrapper? 🤔

If you need dind, we already have a base image you can use that will automatically setup dind when setting DOCKER_IN_DOCKER_ENABLED

This comment has been minimized.

@JoshVanL

JoshVanL Nov 5, 2019
Author Member

I remember having problems with this in the past. Does this require bazel?

This comment has been minimized.

@JoshVanL

JoshVanL Nov 5, 2019
Author Member

To set up that is

This comment has been minimized.

@munnerz

munnerz Nov 7, 2019
Contributor

Nope it doesn't

@JoshVanL
Copy link
Member Author

@JoshVanL JoshVanL commented Nov 8, 2019

/hold

@JoshVanL
Copy link
Member Author

@JoshVanL JoshVanL commented Nov 8, 2019

/unassign @munnerz
/assign

JoshVanL added 3 commits Nov 5, 2019
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL JoshVanL force-pushed the JoshVanL:cert-manager-csi branch from 9319644 to e4bdeb5 Dec 10, 2019
@JoshVanL
Copy link
Member Author

@JoshVanL JoshVanL commented Dec 10, 2019

/hold cancel
/unassign
/assign @munnerz

@munnerz
Copy link
Contributor

@munnerz munnerz commented Dec 11, 2019

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm label Dec 11, 2019
@jetstack-bot
Copy link
Collaborator

@jetstack-bot jetstack-bot commented Dec 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@munnerz
Copy link
Contributor

@munnerz munnerz commented Dec 11, 2019

/hold

containers:
- image: eu.gcr.io/jetstack-build-infra-images/golang-dind:20191205-e920769-1.13.4
args:
- make

This comment has been minimized.

@munnerz

munnerz Dec 11, 2019
Contributor

If you are using dind, you'll need to prepend runner as an arg here in order to start the initialisation script (i.e. to start the docker daemon). Same on the verify job.

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot removed the lgtm label Dec 11, 2019
@JoshVanL
Copy link
Member Author

@JoshVanL JoshVanL commented Dec 11, 2019

Back to you @munnerz

@JoshVanL
Copy link
Member Author

@JoshVanL JoshVanL commented Dec 11, 2019

/hold cancel

@munnerz
Copy link
Contributor

@munnerz munnerz commented Dec 11, 2019

/lgtm

@jetstack-bot jetstack-bot added the lgtm label Dec 11, 2019
@jetstack-bot jetstack-bot merged commit 9cf9e95 into jetstack:master Dec 11, 2019
4 of 5 checks passed
4 of 5 checks passed
tide Not mergeable. Needs lgtm label.
Details
dco All commits have Signed-off-by
Details
pull-testing-build Job succeeded.
Details
pull-testing-config Job succeeded.
Details
pull-testing-verify Job succeeded.
Details
@jetstack-bot
Copy link
Collaborator

@jetstack-bot jetstack-bot commented Dec 11, 2019

@JoshVanL: Updated the following 4 configmaps:

  • config configmap in namespace default using the following files:
    • key config.yaml using file config/config.yaml
  • job-config configmap in namespace default using the following files:
    • key cert-manager-csi-presubmits.yaml using file config/jobs/cert-manager-csi/cert-manager-csi-presubmits.yaml
  • label-config configmap in namespace default using the following files:
    • key labels.yaml using file config/labels.yaml
  • plugins configmap in namespace default using the following files:
    • key plugins.yaml using file config/plugins.yaml

In response to this:

Signed-off-by: JoshVanL vleeuwenjoshua@gmail.com

Adds presubmit jobs and other config for the CSI driver.

Will add periodic jobs once things are looking good.

/assign @munnerz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.