★ wanayoo — archive 1999 https://github.com/linode/docs/pull/3839Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions #3839

Open
wants to merge 4 commits into
base: develop
from
Open

GitHub actions #3839

wants to merge 4 commits into from

Conversation

@Jskobos
Copy link
Contributor

@Jskobos Jskobos commented Dec 7, 2020 •

Move from Travis to GH Actions

This workflow will run on every pull request. It will run the three tasks currently run by Travis, to wit:

  1. Blueberry (assorted tests)
  2. Vale (syntax-aware linting and spell checking) -- only run on modified files
  3. 404: Checks internal links against a local Hugo server

To test, change pull_request on line 3 of test.yaml to push and push some changes to this branch on your fork. Try to modify some files in ways that you would expect a properly-configured Vale etc. to catch (e.g. use words that are not allowed by our Linode-specific dictionary). Go to your fork's GitHub page and check the "Actions" tab to see output.

@Jskobos Jskobos requested a review from nmelehan Dec 7, 2020
@Jskobos Jskobos self-assigned this Dec 7, 2020
@nmelehan
Copy link
Collaborator

@nmelehan nmelehan commented Dec 7, 2020 •

✔️ Deploy preview for nostalgic-ptolemy-b01ab8 ready!

🔨 Explore the source changes: d9e259f

🔍 Inspect the deploy logs: https://app.netlify.com/sites/nostalgic-ptolemy-b01ab8/deploys/5fd7d0ad9e58550007b6e22b

😎 Browse the preview: https://deploy-preview-3839--nostalgic-ptolemy-b01ab8.netlify.app

@leslitagordita
Copy link
Collaborator

@leslitagordita leslitagordita commented Dec 11, 2020

@Jskobos I tested your PR, like you indicated. I see the GitHub Actions tab on my fork and the tests look like they run, but they don't fail. I added misspellings and broken links and both blueberry and 404 tests pass.
Screen Shot 2020-12-11 at 4 40 49 PM

Here is the branch that I'm looking at: https://github.com/leslitagordita/docs/commits/github-actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.