★ wanayoo — archive 1999 https://github.com/livecode/livecode/pull/6309Nouvelle recherche | Portail wanayoo
Skip to content

/ livecode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix extension build scripts #6309

Merged
merged 19 commits into from Mar 5, 2018
Merged

Bugfix extension build scripts #6309

merged 19 commits into from Mar 5, 2018

Conversation

@livecodeali
Copy link
Member

@livecodeali livecodeali commented Jan 31, 2018

This patch will get extension packages building on Windows again
@livecodeali livecodeali added the WIP label Jan 31, 2018
@livecodeali livecodeali added this to the 9.0.0-rc-1 milestone Jan 31, 2018
@livecodeali livecodeali force-pushed the livecodeali:bugfix-extension_build_scripts branch 5 times, most recently from 7b71dfb to 72b69ca Feb 2, 2018
@livecodeali livecodeali force-pushed the livecodeali:bugfix-extension_build_scripts branch 2 times, most recently from b07dbf9 to bc99136 Mar 1, 2018
livecodeali added 13 commits Jan 31, 2018
@livecodeali
[[ PackageExtensions ]] Remove shell cmds from build script
ba4e1d8
@livecodeali
[[ PackageExtensions ]] Convert args to readable var names
97eabcd
@livecodeali
[[ PackageExtensions ]] Refactor into main handler
53a4617
@livecodeali
[[ PackageExtensions ]] Load revzip external and remove other shell cmds
e991194
@livecodeali
[[ PackageExtensions ]] Re-add old shell versions
f44bddf
@livecodeali
[[ ExtensionPackages ]] Move utilities to a script library
532008e 
Also plumb in script library to build scripts, and replace a bunch
of shell script with LiveCode.
@livecodeali
[[ PackageExtensions ]] Generate manifest when building LCS extensions
b664577
@livecodeali
[[ ExtensionUtils ]] Rename library
f1b5521
@livecodeali
[[ ExtensionUtils ]] Get things working on windows
c409015
@livecodeali
[[ ExtensionUtils ]] Add shell of docs
6b94ffc
@livecodeali
[[ ExtensionUtils ]] Various tweaks
6f2bb0b
@livecodeali
[[ ExtensionPackageUtils ]] Update API and docs, and remove logging
efd24c6
@livecodeali
[[ ExtensionPackageUtils ]] Update gyp
1986191
@livecodeali livecodeali force-pushed the livecodeali:bugfix-extension_build_scripts branch from bc99136 to 3dc4b57 Mar 1, 2018
@livecodeali livecodeali mentioned this pull request Mar 1, 2018
Merged
@livecodeali livecodeali added the WIP label Mar 1, 2018
livecodeali added 2 commits Mar 1, 2018
@livecodeali
[[ ExtensionPackageUtils ]] Move more code from ide extension libs
2a52144 
In particular, move the packaging code from
revIDEDeveloperExtensionLibrary, so that we specify exactly what files
are put in the package rather than recursively zipping the extension
folder
@livecodeali
[[ Docs ]] Complete docs for all extensions' handlers and props
4f71ffe
@livecodeali
[[ ExtensionPackageUtils ]] Fix test running
Loading status checks…
174e057
@livecodeali livecodeali force-pushed the livecodeali:bugfix-extension_build_scripts branch from 0a47f91 to 174e057 Mar 1, 2018
@livecodeali
[[ ExtensionPackageUtils ]] Add release notes
Loading status checks…
202ec32
@livecodeali
Copy link
Member Author

@livecodeali livecodeali commented Mar 1, 2018

I think since all these functions are used during build / running IDE, they will be well-tested for now.
livecodeali added 2 commits Mar 2, 2018
@livecodeali
[[ ExtensionPackageUtils ]] Fix assembly building
cce9f7f
@livecodeali
[[ ExtensionPackageUtils ]] Move server script to resources folder
Loading status checks…
2a37058 
There's not really an ideal place for something like a server
script that provides access to an extension, so move it to resources
folder for now.
@livecodeali
Copy link
Member Author

@livecodeali livecodeali commented Mar 2, 2018

Check branch: #6365
@montegoulding
montegoulding reviewed Mar 4, 2018
View changes
extensions/script-libraries/extension-utils/extension-utils.livecodescript

Summary: This library provides handlers for managing livecode extension packages

Version: 1.0.0

This comment has been minimized.

Sign in to view
@montegoulding

montegoulding Mar 4, 2018
Member

@livecodeali do we have a flag we can add here to indicate this is an IDE library?

This comment has been minimized.

Sign in to view
@livecodeali

livecodeali Mar 5, 2018
Author Member

Not yet I don't think...
@montegoulding
montegoulding reviewed Mar 4, 2018
View changes
extensions/script-libraries/extension-utils/extension-utils.livecodescript
end __dependencyOrder

private function __extensionIsBuiltin pID
switch pID

This comment has been minimized.

Sign in to view
@montegoulding

montegoulding Mar 4, 2018
Member

@livecodeali this seems like something we might want to add an enhancement request for a function
@montegoulding
Copy link
Member

@montegoulding montegoulding commented Mar 4, 2018

@livecode-vulcan review ok 2a37058
@livecode-vulcan
Copy link
Contributor

@livecode-vulcan livecode-vulcan commented Mar 4, 2018

💙 review by @montegoulding ok 2a37058
livecode-vulcan added a commit that referenced this pull request Mar 4, 2018
@livecode-vulcan
Auto-merge pull request #6309 from livecodeali/bugfix-extension_build…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
21f920c 
…_scripts

Bugfix extension build scripts

This patch will get extension packages building on Windows again
@livecode-vulcan
Copy link
Contributor

@livecode-vulcan livecode-vulcan commented Mar 5, 2018

😎 test success 2a37058

  • try-community-armv6-android-api8: success
  • try-community-armv6-android-api9: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos11.2: success
  • try-community-universal-ios-iphonesimulator11.2: success
  • try-community-universal-mac-macosx10.6: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian7: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian7: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success
@livecodeali livecodeali merged commit b8d7174 into livecode:develop Mar 5, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/vulcan/cla Contributor Agreement signed by @livecodeali
continuous-integration/vulcan/pr The Vulcan build succeeded on 13 builders
continuous-integration/vulcan/review Approved by reviewer @montegoulding
@livecodeali livecodeali deleted the livecodeali:bugfix-extension_build_scripts branch Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montegoulding montegoulding

Assignees
No one assigned
Labels
vulcan/reviewed
Projects
None yet
Milestone
9.0.0-rc-1
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@livecodeali @montegoulding @livecode-vulcan
You can’t perform that action at this time.